From: Bastien <bzg@gnu.org>
To: Oleh <ohwoeowho@gmail.com>
Cc: org mode <emacs-orgmode@gnu.org>
Subject: Re: `org-attach-file-list' doesn't allow dotfiles
Date: Tue, 18 Mar 2014 17:19:07 +0100 [thread overview]
Message-ID: <87d2hjfpj8.fsf@bzg.ath.cx> (raw)
In-Reply-To: <CAA01p3oR40R-HjGcRoqsnsRzDPWgyvEH_FwRsfidgcQcABkKeA@mail.gmail.com> (Oleh's message of "Mon, 10 Mar 2014 16:46:00 +0100")
Hi Oleh,
Oleh <ohwoeowho@gmail.com> writes:
> I would modify it like this to ignore just "." and "..":
>
> --- a/lisp/org-attach.el
> +++ b/lisp/org-attach.el
> @@ -425,7 +425,7 @@ This can be used after files have been added
> externally."
> "Return a list of files in the attachment directory.
> This ignores files starting with a \".\", and files ending in \"~\"."
> (delq nil
> - (mapcar (lambda (x) (if (string-match "^\\." x) nil x))
> + (mapcar (lambda (x) (if (string-match "^\\.\\.?$" x) nil x))
> (directory-files dir nil "[^~]\\'"))))
I pushed a slightly different change:
http://orgmode.org/cgit.cgi/org-mode.git/commit/?id=74162d9e
> Is there a reason behind this dot file restriction? Would anything break
> if the proposed change was made?
I cannot think of any and John seems too busy right now.
Let's continue with this change and see if anything breaks.
Thanks,
--
Bastien
prev parent reply other threads:[~2014-03-18 16:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-10 15:46 `org-attach-file-list' doesn't allow dotfiles Oleh
2014-03-12 18:39 ` Bastien
2014-04-01 20:20 ` John Wiegley
2014-04-11 9:44 ` Bastien
2014-03-18 16:19 ` Bastien [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d2hjfpj8.fsf@bzg.ath.cx \
--to=bzg@gnu.org \
--cc=emacs-orgmode@gnu.org \
--cc=ohwoeowho@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).