From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bastien Subject: Re: `org-attach-file-list' doesn't allow dotfiles Date: Tue, 18 Mar 2014 17:19:07 +0100 Message-ID: <87d2hjfpj8.fsf@bzg.ath.cx> References: Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:53408) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WPwjo-0000gJ-UX for emacs-orgmode@gnu.org; Tue, 18 Mar 2014 12:19:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WPwjj-0000Hr-Il for emacs-orgmode@gnu.org; Tue, 18 Mar 2014 12:19:36 -0400 Received: from rs249.mailgun.us ([209.61.151.249]:50321) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WPwjj-0000HZ-DP for emacs-orgmode@gnu.org; Tue, 18 Mar 2014 12:19:31 -0400 In-Reply-To: (Oleh's message of "Mon, 10 Mar 2014 16:46:00 +0100") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Oleh Cc: org mode Hi Oleh, Oleh writes: > I would modify it like this to ignore just "." and "..": > > --- a/lisp/org-attach.el > +++ b/lisp/org-attach.el > @@ -425,7 +425,7 @@ This can be used after files have been added > externally." > "Return a list of files in the attachment directory. > This ignores files starting with a \".\", and files ending in \"~\"." > (delq nil > - (mapcar (lambda (x) (if (string-match "^\\." x) nil x)) > + (mapcar (lambda (x) (if (string-match "^\\.\\.?$" x) nil x)) > (directory-files dir nil "[^~]\\'")))) I pushed a slightly different change: http://orgmode.org/cgit.cgi/org-mode.git/commit/?id=74162d9e > Is there a reason behind this dot file restriction? Would anything break > if the proposed change was made? I cannot think of any and John seems too busy right now. Let's continue with this change and see if anything breaks. Thanks, -- Bastien