From: Bastien <bzg@altern.org>
To: Daimrod <daimrod@gmail.com>
Cc: Nicolas Richard <theonewiththeevillook@yahoo.fr>,
17746@debbugs.gnu.org, David Griffiths <dogriffiths@gmail.com>
Subject: bug#17746: bug#17746: 24.4.50; "byte-code: `recenter'ing a window that does not display current-buffer." when composing a message
Date: Sat, 14 Jun 2014 08:46:03 +0200 [thread overview]
Message-ID: <87d2ecgf9w.fsf__32226.2984155261$1402728481$gmane$org@bzg.ath.cx> (raw)
In-Reply-To: <87oaxw9nlh.fsf__3876.62337529964$1402716590$gmane$org@tanger.home> (daimrod@gmail.com's message of "Sat, 14 Jun 2014 12:28:10 +0900")
Daimrod <daimrod@gmail.com> writes:
> In `org-fix-ellipsis-at-bol', the change wasn't
> : (save-excursion (set-window-start (selected-window) (window-start)))
>
> but
> : (save-excursion (set-window-start (selected-window) (point-min)))
>
> which is not a noop.
>
> But it does the wrong thing with isearch.
Yes, it was a silly mistake of mine.
> When isearch is done, that is, when it has found a match and we leave
> isearch with RET for example. Then it calls `isearch-done' which runs
> `org-fix-ellipsis-at-bol' because it is in `isearch-mode-end-hook' (I
> didn't look to find why).
The bug `org-fix-ellipsis-at-bol' is supposed to fix is this one:
sometimes when searching for a string and hitting RET, the beginning
of the buffer is hidden and there is a confusing "..." at the top of
the window. With the previous version (using `recenter'), those
ellipsis were removed by recentering. My bold and kinda superstitious
hope was that `set-window-start' would have the same effect, but I
need to double-check this. At least we don't have the warning.
--
Bastien
next prev parent reply other threads:[~2014-06-14 6:47 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <m2ha3tdrt6.fsf@gmail.com>
[not found] ` <837g4o1x3r.fsf@gnu.org>
[not found] ` <CALMze+rsDUB3seBY2LvbmSuSJouh4C4Avez9uwQWreriDgtFOw@mail.gmail.com>
[not found] ` <87r42vlavi.fsf@geodiff-mac3.ulb.ac.be>
2014-06-11 15:50 ` bug#17746: 24.4.50; "byte-code: `recenter'ing a window that does not display current-buffer." when composing a message Bastien
[not found] ` <87ha3rxx79.fsf@bzg.ath.cx>
2014-06-11 16:09 ` Nicolas Richard
2014-06-11 16:25 ` Bastien
2014-06-11 19:11 ` Nicolas Richard
2014-06-11 16:29 ` Eli Zaretskii
2014-06-11 18:15 ` Stefan Monnier
2014-06-11 18:38 ` Eli Zaretskii
2014-06-12 1:15 ` bug#17746: " Daimrod
[not found] ` <87ppifudvd.fsf@tanger.home>
2014-06-12 2:44 ` Stefan Monnier
2014-06-12 4:10 ` Daimrod
2014-06-12 8:16 ` Nicolas Richard
[not found] ` <878up24k6j.fsf@yahoo.fr>
2014-06-12 8:58 ` Daimrod
[not found] ` <878up2ec7z.fsf@tanger.home>
2014-06-12 9:27 ` Daimrod
2014-06-12 10:06 ` Bastien
2014-06-13 12:58 ` Nicolas Richard
2014-06-13 15:29 ` Bastien
[not found] ` <8761k46d56.fsf@bzg.ath.cx>
2014-06-14 3:28 ` Daimrod
[not found] ` <87oaxw9nlh.fsf__3876.62337529964$1402716590$gmane$org@tanger.home>
2014-06-14 6:46 ` Bastien [this message]
[not found] ` <874mzqeaug.fsf@tanger.home>
2014-06-12 10:12 ` Daimrod
2014-06-12 13:04 ` Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='87d2ecgf9w.fsf__32226.2984155261$1402728481$gmane$org@bzg.ath.cx' \
--to=bzg@altern.org \
--cc=17746@debbugs.gnu.org \
--cc=daimrod@gmail.com \
--cc=dogriffiths@gmail.com \
--cc=theonewiththeevillook@yahoo.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).