From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bastien <bzg@altern.org>
Subject: bug#17746: bug#17746: 24.4.50; "byte-code: `recenter'ing a window
 that does not display current-buffer." when composing a message
Date: Sat, 14 Jun 2014 08:46:03 +0200
Message-ID: <87d2ecgf9w.fsf__32226.2984155261$1402728481$gmane$org@bzg.ath.cx>
References: <m2ha3tdrt6.fsf@gmail.com>
	<837g4o1x3r.fsf@gnu.org>	<CALMze+rsDUB3seBY2LvbmSuSJouh4C4Avez9uwQWreriDgtFOw@mail.gmail.com>	<87r42vlavi.fsf@geodiff-mac3.ulb.ac.be>
	<87ha3rxx79.fsf@bzg.ath.cx>	<87ppifudvd.fsf@tanger.home>
	<878up24k6j.fsf@yahoo.fr>	<878up2ec7z.fsf@tanger.home>	<874mzqeaug.fsf__22767.2755755068$1402565401$gmane$org@tanger.home>	<87lht2l9vo.fsf__32258.4286136136$1402567739$gmane$org@bzg.ath.cx>	<87ioo56k5h.fsf@geodiff-mac3.ulb.ac.be>
	<8761k46d56.fsf@bzg.ath.cx>	<87oaxw9nlh.fsf__3876.62337529964$1402716590$gmane$org@tanger.home>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36619)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1Wvhk5-0004xt-Fb
	for emacs-orgmode@gnu.org; Sat, 14 Jun 2014 02:47:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1Wvhjy-0005Pl-Vh
	for emacs-orgmode@gnu.org; Sat, 14 Jun 2014 02:47:09 -0400
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.17746.B17746.14027283791805@debbugs.gnu.org>
In-Reply-To: <87oaxw9nlh.fsf__3876.62337529964$1402716590$gmane$org@tanger.home>	(daimrod@gmail.com's
	message of "Sat, 14 Jun 2014 12:28:10 +0900")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Daimrod <daimrod@gmail.com>
Cc: Nicolas Richard <theonewiththeevillook@yahoo.fr>, 17746@debbugs.gnu.org, David Griffiths <dogriffiths@gmail.com>

Daimrod <daimrod@gmail.com> writes:

> In `org-fix-ellipsis-at-bol', the change wasn't
> : (save-excursion (set-window-start (selected-window) (window-start)))
>
> but
> : (save-excursion (set-window-start (selected-window) (point-min)))
>
> which is not a noop.
>
> But it does the wrong thing with isearch.

Yes, it was a silly mistake of mine.

> When isearch is done, that is, when it has found a match and we leave
> isearch with RET for example. Then it calls `isearch-done' which runs
> `org-fix-ellipsis-at-bol' because it is in `isearch-mode-end-hook' (I
> didn't look to find why).

The bug `org-fix-ellipsis-at-bol' is supposed to fix is this one:
sometimes when searching for a string and hitting RET, the beginning
of the buffer is hidden and there is a confusing "..." at the top of
the window.  With the previous version (using `recenter'), those
ellipsis were removed by recentering.  My bold and kinda superstitious
hope was that `set-window-start' would have the same effect, but I
need to double-check this.  At least we don't have the warning.

-- 
 Bastien