From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Org Mode <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] Ensure org-get-tags includes all local tags
Date: Tue, 05 Jun 2018 20:40:12 +0200 [thread overview]
Message-ID: <87d0x56prn.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <878t7tm8tf.fsf@fastmail.fm> (Matt Lundin's message of "Tue, 05 Jun 2018 12:39:40 -0500")
Hello,
Matt Lundin <mdl@imapmail.org> writes:
> With commit fbe56f89f75a8979e0ba48001a822518df2c66fe, the function
> org-get-tags incorrectly removes uninherited tags from the list of tags
> it returns, *even if* they are local tags.
>
> Expected behavior: org-get-tags should always return local tags,
> regardless of whether they are excluded from inheritance. The variable
> org-tags-exclude-from-inheritance should only apply to tags in parent
> heading or to file tags.
>
> Actual behavior: if a local tag is in org-tags-exclude-from-inheritance,
> org-get-tags will not return it.
>
> This causes problems with functions that call org-get-tags. For
> instance, if org-fast-tag-selection-single-key is set,
> org-set-tags-command delete all local tags that are in the list
> org-tags-exclude-from-inheritance.
>
> I've attached a patch that fixes the issue.
You're right. Thank you.
Could you add a regression test for this and push the change?
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2018-06-05 18:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-05 17:39 [PATCH] Ensure org-get-tags includes all local tags Matt Lundin
2018-06-05 18:40 ` Nicolas Goaziou [this message]
2018-07-25 12:57 ` Matt Lundin
2018-08-19 8:29 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d0x56prn.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).