From: Matt Lundin <mdl@imapmail.org>
To: Org Mode <emacs-orgmode@gnu.org>
Subject: [PATCH] Ensure org-get-tags includes all local tags
Date: Tue, 05 Jun 2018 12:39:40 -0500 [thread overview]
Message-ID: <878t7tm8tf.fsf@fastmail.fm> (raw)
[-- Attachment #1: Type: text/plain, Size: 799 bytes --]
With commit fbe56f89f75a8979e0ba48001a822518df2c66fe, the function
org-get-tags incorrectly removes uninherited tags from the list of tags
it returns, *even if* they are local tags.
Expected behavior: org-get-tags should always return local tags,
regardless of whether they are excluded from inheritance. The variable
org-tags-exclude-from-inheritance should only apply to tags in parent
heading or to file tags.
Actual behavior: if a local tag is in org-tags-exclude-from-inheritance,
org-get-tags will not return it.
This causes problems with functions that call org-get-tags. For
instance, if org-fast-tag-selection-single-key is set,
org-set-tags-command delete all local tags that are in the list
org-tags-exclude-from-inheritance.
I've attached a patch that fixes the issue.
Best,
Matt
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Ensure-org-get-tags-returns-all-local-tags.patch --]
[-- Type: text/x-patch, Size: 988 bytes --]
From 407c9c88f7c8629ae99fed5060ef2c428b54ebd8 Mon Sep 17 00:00:00 2001
From: Matt Lundin <mdl@imapmail.org>
Date: Tue, 5 Jun 2018 12:31:42 -0500
Subject: [PATCH] Ensure org-get-tags returns all local tags
* lisp/org.el: (org-get-tags) Fix a bug that removed local tags if
they were in the org-tags-exclude-from-inheritance list.
---
lisp/org.el | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lisp/org.el b/lisp/org.el
index d2b4c26ff..8cfb64510 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -14713,8 +14713,8 @@ Inherited tags have the `inherited' text property."
(setq tags (append (mapcar #'org-add-prop-inherited
(org--get-local-tags))
tags)))
- (org-remove-uninherited-tags
- (delete-dups (append org-file-tags tags)))))))))
+ (delete-dups (append (org-remove-uninherited-tags org-file-tags)
+ tags))))))))
(defun org-get-buffer-tags ()
"Get a table of all tags used in the buffer, for completion."
--
2.17.1
next reply other threads:[~2018-06-05 17:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-05 17:39 Matt Lundin [this message]
2018-06-05 18:40 ` [PATCH] Ensure org-get-tags includes all local tags Nicolas Goaziou
2018-07-25 12:57 ` Matt Lundin
2018-08-19 8:29 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878t7tm8tf.fsf@fastmail.fm \
--to=mdl@imapmail.org \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).