* Bug: org-sort-entries does not preserve folded drawers [9.1.13 (9.1.13-dist @ /home/yantar92/.emacs.d/straight/build/org/)]
@ 2019-08-03 6:19 Ihor Radchenko
2019-08-10 6:00 ` Carsten Dominik
0 siblings, 1 reply; 3+ messages in thread
From: Ihor Radchenko @ 2019-08-03 6:19 UTC (permalink / raw)
To: emacs-orgmode
org-sort-entries seems to unfold everything in the subtree even if no
modification was done to the buffer during sorting.
Steps to reproduce:
Consider the following org file:
#+begin_src org
,* a
:PROPERTIES:
:ID: 279e797c-f4a7-47bb-80f6-e72ac6f3ec55
:END:
:DRAWER:
Blah
:END:
,** test
#+end_src
1. emacs -Q
2. Fold all the drawers and entries in the buffer
3a. Call M-x org-sort-entries p
3b. Call M-: (org-sort-entries nil ?p) RET
Expected behaviour for 3a: Subtree is unfolded, all the property drawers
are folded, buffer is unchanged
Observed behaviour for 3a: Subtree is unfolded, all the property drawers
are also unfolded, buffer is marked modified
Expected behaviour for 3b: Subtree is folded, all the property drawers
are folded, buffer is unchanged
Observed behaviour for 3b: Subtree is unfolded, all the property drawers
are also unfolded, buffer is marked modified
Regards,
Ihor
Emacs : GNU Emacs 27.0.50 (build 1, x86_64-pc-linux-gnu, X toolkit)
of 2019-04-29
Package: Org mode version 9.1.13 (9.1.13-dist @ /home/yantar92/.emacs.d/straight/build/org/)
--
Ihor Radchenko,
PhD,
Center for Advancing Materials Performance from the Nanoscale (CAMP-nano)
State Key Laboratory for Mechanical Behavior of Materials, Xi'an Jiaotong University, Xi'an, China
Email: yantar92@gmail.com, ihor_radchenko@alumni.sutd.edu.sg
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Bug: org-sort-entries does not preserve folded drawers [9.1.13 (9.1.13-dist @ /home/yantar92/.emacs.d/straight/build/org/)]
2019-08-03 6:19 Bug: org-sort-entries does not preserve folded drawers [9.1.13 (9.1.13-dist @ /home/yantar92/.emacs.d/straight/build/org/)] Ihor Radchenko
@ 2019-08-10 6:00 ` Carsten Dominik
2019-08-19 1:52 ` Ihor Radchenko
0 siblings, 1 reply; 3+ messages in thread
From: Carsten Dominik @ 2019-08-10 6:00 UTC (permalink / raw)
To: Ihor Radchenko; +Cc: org-mode list
[-- Attachment #1: Type: text/plain, Size: 1754 bytes --]
Hi Ihor,
thank you for the report.
It would be too much work to *preserve* the visibility state of everything
in the sorting area, but you are right, the drawers at lease should be
closed. I fixed this, the fix is in master.
Carsten
On Sat, Aug 3, 2019 at 8:22 AM Ihor Radchenko <yantar92@gmail.com> wrote:
>
> org-sort-entries seems to unfold everything in the subtree even if no
> modification was done to the buffer during sorting.
>
> Steps to reproduce:
>
> Consider the following org file:
> #+begin_src org
> ,* a
> :PROPERTIES:
> :ID: 279e797c-f4a7-47bb-80f6-e72ac6f3ec55
> :END:
> :DRAWER:
> Blah
> :END:
>
> ,** test
> #+end_src
>
> 1. emacs -Q
> 2. Fold all the drawers and entries in the buffer
> 3a. Call M-x org-sort-entries p
> 3b. Call M-: (org-sort-entries nil ?p) RET
>
>
> Expected behaviour for 3a: Subtree is unfolded, all the property drawers
> are folded, buffer is unchanged
> Observed behaviour for 3a: Subtree is unfolded, all the property drawers
> are also unfolded, buffer is marked modified
>
> Expected behaviour for 3b: Subtree is folded, all the property drawers
> are folded, buffer is unchanged
> Observed behaviour for 3b: Subtree is unfolded, all the property drawers
> are also unfolded, buffer is marked modified
>
> Regards,
> Ihor
>
>
>
>
> Emacs : GNU Emacs 27.0.50 (build 1, x86_64-pc-linux-gnu, X toolkit)
> of 2019-04-29
> Package: Org mode version 9.1.13 (9.1.13-dist @
> /home/yantar92/.emacs.d/straight/build/org/)
> --
> Ihor Radchenko,
> PhD,
> Center for Advancing Materials Performance from the Nanoscale (CAMP-nano)
> State Key Laboratory for Mechanical Behavior of Materials, Xi'an Jiaotong
> University, Xi'an, China
> Email: yantar92@gmail.com, ihor_radchenko@alumni.sutd.edu.sg
>
>
>
[-- Attachment #2: Type: text/html, Size: 2398 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Bug: org-sort-entries does not preserve folded drawers [9.1.13 (9.1.13-dist @ /home/yantar92/.emacs.d/straight/build/org/)]
2019-08-10 6:00 ` Carsten Dominik
@ 2019-08-19 1:52 ` Ihor Radchenko
0 siblings, 0 replies; 3+ messages in thread
From: Ihor Radchenko @ 2019-08-19 1:52 UTC (permalink / raw)
To: Carsten Dominik; +Cc: org-mode list
Thanks!
Carsten Dominik <dominik@uva.nl> writes:
> Hi Ihor,
>
> thank you for the report.
> It would be too much work to *preserve* the visibility state of everything
> in the sorting area, but you are right, the drawers at lease should be
> closed. I fixed this, the fix is in master.
>
> Carsten
>
> On Sat, Aug 3, 2019 at 8:22 AM Ihor Radchenko <yantar92@gmail.com> wrote:
>
>>
>> org-sort-entries seems to unfold everything in the subtree even if no
>> modification was done to the buffer during sorting.
>>
>> Steps to reproduce:
>>
>> Consider the following org file:
>> #+begin_src org
>> ,* a
>> :PROPERTIES:
>> :ID: 279e797c-f4a7-47bb-80f6-e72ac6f3ec55
>> :END:
>> :DRAWER:
>> Blah
>> :END:
>>
>> ,** test
>> #+end_src
>>
>> 1. emacs -Q
>> 2. Fold all the drawers and entries in the buffer
>> 3a. Call M-x org-sort-entries p
>> 3b. Call M-: (org-sort-entries nil ?p) RET
>>
>>
>> Expected behaviour for 3a: Subtree is unfolded, all the property drawers
>> are folded, buffer is unchanged
>> Observed behaviour for 3a: Subtree is unfolded, all the property drawers
>> are also unfolded, buffer is marked modified
>>
>> Expected behaviour for 3b: Subtree is folded, all the property drawers
>> are folded, buffer is unchanged
>> Observed behaviour for 3b: Subtree is unfolded, all the property drawers
>> are also unfolded, buffer is marked modified
>>
>> Regards,
>> Ihor
>>
>>
>>
>>
>> Emacs : GNU Emacs 27.0.50 (build 1, x86_64-pc-linux-gnu, X toolkit)
>> of 2019-04-29
>> Package: Org mode version 9.1.13 (9.1.13-dist @
>> /home/yantar92/.emacs.d/straight/build/org/)
>> --
>> Ihor Radchenko,
>> PhD,
>> Center for Advancing Materials Performance from the Nanoscale (CAMP-nano)
>> State Key Laboratory for Mechanical Behavior of Materials, Xi'an Jiaotong
>> University, Xi'an, China
>> Email: yantar92@gmail.com, ihor_radchenko@alumni.sutd.edu.sg
>>
>>
>>
--
Ihor Radchenko,
PhD,
Center for Advancing Materials Performance from the Nanoscale (CAMP-nano)
State Key Laboratory for Mechanical Behavior of Materials, Xi'an Jiaotong University, Xi'an, China
Email: yantar92@gmail.com, ihor_radchenko@alumni.sutd.edu.sg
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-08-19 1:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-03 6:19 Bug: org-sort-entries does not preserve folded drawers [9.1.13 (9.1.13-dist @ /home/yantar92/.emacs.d/straight/build/org/)] Ihor Radchenko
2019-08-10 6:00 ` Carsten Dominik
2019-08-19 1:52 ` Ihor Radchenko
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).