emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* Revert "Fix encrypt/decrypt in presence of arbitrary drawers"
@ 2020-09-13  8:44 Nicolas Goaziou
  2020-09-13 16:44 ` Bastien
  0 siblings, 1 reply; 3+ messages in thread
From: Nicolas Goaziou @ 2020-09-13  8:44 UTC (permalink / raw)
  To: Org Mode List

Hello,

I suggest to revert commit c93983613dc9bba88f39f81b06a9813060a4599a from
maint and master branch.

By using (org-end-of-meta-data t), _any_ drawer at the beginning of the
entry is left in clear text. This includes personal drawers you would
like to hide. E.g.,

--8<---------------cut here---------------start------------->8---
* Test                                                                     :crypt:

:SECRET:
It's a secret to everyone.
:END:

This is hidden.

# Local Variables:
# org-crypt-key: nil
# End:
--8<---------------cut here---------------end--------------->8---

Since such data is never needed for encryption, I suggest to stay on the
safe side and encrypt anything below the properties drawer.

Regards,
-- 
Nicolas Goaziou


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Revert "Fix encrypt/decrypt in presence of arbitrary drawers"
  2020-09-13  8:44 Revert "Fix encrypt/decrypt in presence of arbitrary drawers" Nicolas Goaziou
@ 2020-09-13 16:44 ` Bastien
  2020-09-13 19:25   ` Nicolas Goaziou
  0 siblings, 1 reply; 3+ messages in thread
From: Bastien @ 2020-09-13 16:44 UTC (permalink / raw)
  To: Nicolas Goaziou; +Cc: Org Mode List

Hi Nicolas,

Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

> I suggest to revert commit c93983613dc9bba88f39f81b06a9813060a4599a from
> maint and master branch.

I pushed a fix in master (755367f36) that should prevent the problem
you are pointing too while fixing the problem the OP reported.

Thanks for reporting this potential issue!

-- 
 Bastien


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Revert "Fix encrypt/decrypt in presence of arbitrary drawers"
  2020-09-13 16:44 ` Bastien
@ 2020-09-13 19:25   ` Nicolas Goaziou
  0 siblings, 0 replies; 3+ messages in thread
From: Nicolas Goaziou @ 2020-09-13 19:25 UTC (permalink / raw)
  To: Bastien; +Cc: Org Mode List

Hello,

Bastien <bzg@gnu.org> writes:

> I pushed a fix in master (755367f36) that should prevent the problem
> you are pointing too while fixing the problem the OP reported.

I think this is still sub-optimal.

`org-logbook-drawer-re' doesn't mean much, because it hard-codes
"LOGBOOK" whereas `org-log-into-drawer' could have an entire different
value, including nil. As long as users can add log notes elsewhere than
into "LOGBOOK" drawer, the check you implemented will not work reliably.

I think encrypted entries should be considered as read-only. You should
not be able to reschedule them, or add a note, as long as
`org-at-encrypted-entry-p' is non-nil. I don't think you can handle the
initial problem otherwise.

Regards,
-- 
Nicolas Goaziou


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-09-13 19:26 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-13  8:44 Revert "Fix encrypt/decrypt in presence of arbitrary drawers" Nicolas Goaziou
2020-09-13 16:44 ` Bastien
2020-09-13 19:25   ` Nicolas Goaziou

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).