* [BUG] Feature request: Add group checks for manual tag setting (not just fast tags) [9.6.6 (release_9.6.6 @ /usr/share/emacs/29.1/lisp/org/)]
@ 2023-09-18 14:13 sreenivas sumadithya
2023-09-19 9:50 ` Ihor Radchenko
0 siblings, 1 reply; 3+ messages in thread
From: sreenivas sumadithya @ 2023-09-18 14:13 UTC (permalink / raw)
To: emacs-orgmode
[-- Attachment #1: Type: text/plain, Size: 4368 bytes --]
Currently, tag groups/ mutually exclusive tags can be set when tags are set
manually (without shortcuts being assigned to the tags / fast tags). Need
the behavior seen in fast tags in manual tagging for tag groups.
Reproduction:
- Create an org file
- "#+tags: {dog cat} mat"
- Save the file after setting this.
- Close buffer
- Open file
- Make a heading
- C-c C-q dog
- C-c C-q cat
Result:
- Both 'cat' and 'dog' are assigned to the heading.
Desired behavior:
- One of the tags should be replaced by the other.
Emacs : GNU Emacs 29.1 (build 1, x86_64-pc-linux-gnu, GTK+ Version
3.24.38, cairo version 1.17.8)
Package: Org mode version 9.6.6 (release_9.6.6 @
/usr/share/emacs/29.1/lisp/org/)
current state:
==============
(setq
org-link-elisp-confirm-function 'yes-or-no-p
org-bibtex-headline-format-function #[257 "\300 \236A\207" [:title] 3
"\n\n(fn ENTRY)"]
org-persist-after-read-hook '(org-element--cache-persist-after-read)
org-export-before-parsing-hook '(org-attach-expand-links)
org-cycle-tab-first-hook '(org-babel-hide-result-toggle-maybe
org-babel-header-arg-expand)
org-archive-hook '(org-attach-archive-delete-maybe)
org-cycle-hook '(org-cycle-hide-archived-subtrees
org-cycle-show-empty-lines
org-cycle-optimize-window-after-visibility-change
org-cycle-display-inline-images)
org-persist-before-read-hook '(org-element--cache-persist-before-read)
org-mode-hook '(#[0 "\300\301\302\303\304$\207" [add-hook
change-major-mode-hook org-fold-show-all append local]
5]
#[0 "\300\301\302\303\304$\207"
[add-hook change-major-mode-hook org-babel-show-result-all append local]
5]
org-babel-result-hide-spec org-babel-hide-all-hashes)
org-confirm-shell-link-function 'yes-or-no-p
outline-isearch-open-invisible-function 'outline-isearch-open-invisible
org-agenda-before-write-hook '(org-agenda-add-entry-text)
org-src-mode-hook '(org-src-babel-configure-edit-buffer
org-src-mode-configure-edit-buffer)
org-confirm-elisp-link-function 'yes-or-no-p
org-speed-command-hook '(org-speed-command-activate
org-babel-speed-command-activate)
org-persist-directory "/tmp/org-persist-yxcGf7"
org-fold-core-isearch-open-function 'org-fold--isearch-reveal
org-persist-before-write-hook '(org-element--cache-persist-before-write)
org-tab-first-hook '(org-babel-hide-result-toggle-maybe
org-babel-header-arg-expand)
org-link-shell-confirm-function 'yes-or-no-p
org-babel-pre-tangle-hook '(save-buffer)
org-agenda-loop-over-headlines-in-active-region nil
org-occur-hook '(org-first-headline-recenter)
org-metadown-hook '(org-babel-pop-to-session-maybe)
org-link-parameters '(("attachment" :follow org-attach-follow :complete
org-attach-complete-link)
("id" :follow org-id-open) ("eww" :follow org-eww-open :store
org-eww-store-link)
("rmail" :follow org-rmail-open :store org-rmail-store-link)
("mhe" :follow org-mhe-open :store org-mhe-store-link)
("irc" :follow org-irc-visit :store org-irc-store-link :export
org-irc-export)
("info" :follow org-info-open :export org-info-export :store
org-info-store-link
:insert-description org-info-description-as-command)
("gnus" :follow org-gnus-open :store org-gnus-store-link)
("docview" :follow org-docview-open :export org-docview-export :store
org-docview-store-link)
("bibtex" :follow org-bibtex-open :store org-bibtex-store-link)
("bbdb" :follow org-bbdb-open :export org-bbdb-export :complete
org-bbdb-complete-link
:store org-bbdb-store-link)
("w3m" :store org-w3m-store-link)
("doi" :follow org-link-doi-open :export org-link-doi-export)
("file+sys") ("file+emacs")
("shell" :follow org-link--open-shell)
("news" :follow
#[514 "\301\300\302 Q \"\207" ["news" browse-url ":"] 6 "\n\n(fn URL ARG)"])
("mailto" :follow
#[514 "\301\300\302 Q \"\207" ["mailto" browse-url ":"] 6 "\n\n(fn URL
ARG)"])
("https" :follow
#[514 "\301\300\302 Q \"\207" ["https" browse-url ":"] 6 "\n\n(fn URL
ARG)"])
("http" :follow
#[514 "\301\300\302 Q \"\207" ["http" browse-url ":"] 6 "\n\n(fn URL ARG)"])
("ftp" :follow #[514 "\301\300\302 Q \"\207" ["ftp" browse-url ":"] 6
"\n\n(fn URL ARG)"])
("help" :follow org-link--open-help :store org-link--store-help)
("file" :complete org-link-complete-file) ("elisp" :follow
org-link--open-elisp))
org-metaup-hook '(org-babel-load-in-session-maybe)
)
[-- Attachment #2: Type: text/html, Size: 5610 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [BUG] Feature request: Add group checks for manual tag setting (not just fast tags) [9.6.6 (release_9.6.6 @ /usr/share/emacs/29.1/lisp/org/)]
2023-09-18 14:13 [BUG] Feature request: Add group checks for manual tag setting (not just fast tags) [9.6.6 (release_9.6.6 @ /usr/share/emacs/29.1/lisp/org/)] sreenivas sumadithya
@ 2023-09-19 9:50 ` Ihor Radchenko
2023-10-20 10:34 ` Ihor Radchenko
0 siblings, 1 reply; 3+ messages in thread
From: Ihor Radchenko @ 2023-09-19 9:50 UTC (permalink / raw)
To: sreenivas sumadithya; +Cc: emacs-orgmode
sreenivas sumadithya <sumadithya@gmail.com> writes:
> Currently, tag groups/ mutually exclusive tags can be set when tags are set
> manually (without shortcuts being assigned to the tags / fast tags). Need
> the behavior seen in fast tags in manual tagging for tag groups.
>
> Reproduction:
> - Create an org file
> - "#+tags: {dog cat} mat"
> - Save the file after setting this.
> - Close buffer
> - Open file
> - Make a heading
> - C-c C-q dog
> - C-c C-q cat
>
> Result:
> - Both 'cat' and 'dog' are assigned to the heading.
>
> Desired behavior:
> - One of the tags should be replaced by the other.
I can only follow the described recipe when setting
org-use-fast-tag-selection to non-standard value of t.
For such scenario, I just pushed a fix onto main - entering group tags
from exclusive groups will now clear already applied tags from the same
group.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=edcb8eca5
In case of the default settings (org-use-fast-tag-selection = auto), the
interface is different - prompt will list all the tags already present
in the heading:
- C-c C-q dog from the recipe will look like
TAGS: <point>
TAGS: dog
* heading :dog:
- Another C-c C-q will, however, yield
TAGS: :dog:<point>
entering "cat" manually
TAGS: :dog:cat
will still force setting both the tags:
* heading :dog:cat:
In the above scenario, there is no non-ambiguous way to know which
exclusive tag is implied by the user. So, I am inclined to keep the
current behavior. Unless there are better ideas.
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [BUG] Feature request: Add group checks for manual tag setting (not just fast tags) [9.6.6 (release_9.6.6 @ /usr/share/emacs/29.1/lisp/org/)]
2023-09-19 9:50 ` Ihor Radchenko
@ 2023-10-20 10:34 ` Ihor Radchenko
0 siblings, 0 replies; 3+ messages in thread
From: Ihor Radchenko @ 2023-10-20 10:34 UTC (permalink / raw)
To: sreenivas sumadithya; +Cc: emacs-orgmode
Ihor Radchenko <yantar92@posteo.net> writes:
> ...
> In case of the default settings (org-use-fast-tag-selection = auto), the
> interface is different - prompt will list all the tags already present
> in the heading:
> ...
> In the above scenario, there is no non-ambiguous way to know which
> exclusive tag is implied by the user. So, I am inclined to keep the
> current behavior. Unless there are better ideas.
I am thus closing this bug, as partially addressed.
Fixed.
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-10-20 10:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-18 14:13 [BUG] Feature request: Add group checks for manual tag setting (not just fast tags) [9.6.6 (release_9.6.6 @ /usr/share/emacs/29.1/lisp/org/)] sreenivas sumadithya
2023-09-19 9:50 ` Ihor Radchenko
2023-10-20 10:34 ` Ihor Radchenko
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).