emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* Keeping an eye on byte-compilation warnings
@ 2011-08-13 21:49 John Wiegley
  2011-08-14  6:39 ` David Maus
                   ` (3 more replies)
  0 siblings, 4 replies; 8+ messages in thread
From: John Wiegley @ 2011-08-13 21:49 UTC (permalink / raw)
  To: emacs-orgmode

Maybe we're all using different versions of Emacs, but I find that
byte-compilation warnings keep increasing as time goes by.  I'd like to ask
people to compile their code before committing, to keep the build log clean.
It looks messy when there are lots of unnecessary warnings.

Here's what I'm seeing now:

--8<---------------cut here---------------start------------->8---
lisp/org.el:

  In end of data:
  org.el:20575:1:Warning: the following functions are not known to be defined:
      org-agenda-todo, org-find-invisible, org-find-visible
--8<---------------cut here---------------end--------------->8---

These represent a cyclic dependency.  Should org.el contain some autoload
forms during compilation?
  
--8<---------------cut here---------------start------------->8---
lisp/org-footnote.el:

  In org-footnote-in-valid-context-p:
  org-footnote.el:185:37:Warning: reference to free variable
      `message-cite-prefix-regexp'
  
  In end of data:
  org-footnote.el:869:1:Warning: the following functions are not known to be
      defined: message-point-in-header-p, org-icompleting-read
--8<---------------cut here---------------end--------------->8---

Is there a reason org-footnote doesn't just require org?

--8<---------------cut here---------------start------------->8---
lisp/org-list.el:

  In org-list-send-item:
  org-list.el:1456:56:Warning: Function `sort*' from cl package called at
      runtime
--8<---------------cut here---------------end--------------->8---

I've fixed this one in d24a141.  There was no reason to use sort* instead of
sort.

--8<---------------cut here---------------start------------->8---
lisp/org-table.el:

  In org-table-eval-formula:
  org-table.el:2437:23:Warning: assignment to free variable
      `duration-output-format'
  org-table.el:2557:34:Warning: reference to free variable
      `duration-output-format'
  
  In org-table-time-string-to-seconds:
  org-table.el:3252:11:Warning: assignment to free variable `minus'
  org-table.el:3257:13:Warning: reference to free variable `minus'
--8<---------------cut here---------------end--------------->8---

I think an empty defvar during compilation is in order here, and that minus is
simply missing from the `let'.

Thanks,
  John

^ permalink raw reply	[flat|nested] 8+ messages in thread
end of thread, other threads:[~2011-08-19 21:54 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-08-13 21:49 Keeping an eye on byte-compilation warnings John Wiegley
2011-08-14  6:39 ` David Maus
2011-08-14  8:14 ` Achim Gratz
2011-08-15  7:46   ` Bastien
2011-08-14 18:25 ` Bastien
2011-08-15  7:46 ` Bastien
2011-08-18 18:08   ` Achim Gratz
2011-08-19 21:55     ` Bastien

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).