emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Achim Gratz <Stromeko@nexgo.de>
To: emacs-orgmode@gnu.org
Subject: Re: [PATCH] org-reload doesn't use full emacs load-path?
Date: Tue, 29 May 2012 21:45:26 +0200	[thread overview]
Message-ID: <87bol6u5yh.fsf@Rainer.invalid> (raw)
In-Reply-To: 877gvvsqiy.fsf@ucl.ac.uk

[-- Attachment #1: Type: text/plain, Size: 282 bytes --]

Eric S Fraga writes:
> For some reason, org tries to load my ob-jacaranda.el from where org
> itself sits despite ob-jacaranda.el being in one of the directories in
> the load-path.

That would have been me, but it was obviously the wrong thing to do.
Patch attached, please test.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: fix org-reload --]
[-- Type: text/x-patch, Size: 1010 bytes --]

From 3234f4ed6329240101172f823931f5b2a0c4fa6f Mon Sep 17 00:00:00 2001
From: Achim Gratz <Stromeko@Stromeko.DE>
Date: Tue, 29 May 2012 21:43:27 +0200
Subject: [PATCH] Revert an undesirable change in org-reload.

* lisp/org.el (org-reload): Revert an undesirable change in
  org-reload.  Do not prepend org-dir to babel-files, which prevents
  the files from being found in load-path.
---
 lisp/org.el |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/org.el b/lisp/org.el
index 1f8e13f..0a1fd35 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -19604,7 +19604,7 @@ (defun org-reload (&optional uncompiled)
 			   (file-name-directory
 			    (org-find-library-dir "org-contribdir"))))
 	 (babel-files
-	  (mapcar (lambda (el) (concat  (concat dir-org "ob") (when el (format "-%s" el)) ".el"))
+	  (mapcar (lambda (el) (concat "ob" (when el (format "-%s" el)) ".el"))
 		  (append (list nil "comint" "eval" "exp" "keys"
 				    "lob" "ref" "table" "tangle")
 			  (delq nil
-- 
1.7.9.2


[-- Attachment #3: Type: text/plain, Size: 877 bytes --]


> One possible worry: even with emacs -Q, I get org-version returning the
> following:
>
> Org-mode version 7.8.10 (release_7.8.10-619-g540dfc @ mixed installation! /usr/share/emacs/24.1.50/lisp/org/ and /home/ucecesf/git/org-mode/lisp/)
>
> Note the "mixed installation" bit.  I've never seen this before.  

It tells you that org-install is found in a different place than org.
This probably means you haven't done a 'make autoloads' or more likely
in your case a 'make uncompiled' and are relying on the autoload
definitions from a different org version than the one you are using.
You can't expect that to work and this is a gentle reminder to fix it
before it falls over.


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

Factory and User Sound Singles for Waldorf Blofeld:
http://Synth.Stromeko.net/Downloads.html#WaldorfSounds

  reply	other threads:[~2012-05-29 19:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-29  1:51 [bug] [babel] org-reload doesn't use full emacs load-path? Eric S Fraga
2012-05-29 19:45 ` Achim Gratz [this message]
2012-05-30  7:45   ` [PATCH] " Eric S Fraga
2012-05-31  2:20   ` Eric S Fraga
2012-05-31 18:35     ` Achim Gratz
2012-06-01  8:14       ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bol6u5yh.fsf@Rainer.invalid \
    --to=stromeko@nexgo.de \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).