emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Adam Porter <adam@alphapapa.net>
To: emacs-orgmode@gnu.org
Subject: Re: [RFC] Org document concept + document property drawers
Date: Sun, 01 Sep 2019 00:20:48 -0500	[thread overview]
Message-ID: <87blw4lhhr.fsf@alphapapa.net> (raw)
In-Reply-To: HE1PR02MB30335B0720ABF7B9780A305FDABC0@HE1PR02MB3033.eurprd02.prod.outlook.com

Gustav Wikström <gustav@whil.se> writes:

> I'm continuing on my proposal to introduce a "document" element in
> org-mode and the idea of seeing everything before the first headline
> as the base level 0 outline for a file. I've attached two patches that
> I'd like some public review of before pushing to master.
>
> Patch 0001 introduces the document element into org-element.el, and
> some restructuring related to that.
>
> Patch 0002 makes it possible to use property drawers at the document
> level. I've hopefully covered all related commands to make this work.
> And I've added a bunch of tests to guard against future regressions.
>
> Waiting for your comments!

This is a very interesting idea, and I don't want to dismiss your work,
but I am concerned about how much third-party code will likely break by
changing the results returned by org-element for parsing an Org buffer.
I haven't thoroughly studied all of the code in your patches, so I may
be wrong, but I think the breakage could be extensive.  For example,
simple operations like destructuring the results of org-element parsing
functions may be broken.  Have you done any investigation into this
issue?

Maybe there should be a transitional period in which the existing
org-element parsing functions would work as before, and the new
document-level elements would be returned by a new org-element
document-level parsing function.  Frankly, if there is breakage,the
transition would probably take a few years, because there is a lot of
code out there that has worked for years and may not be updated or
replaced for years.

  reply	other threads:[~2019-09-01  5:21 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-31 18:49 [RFC] Org document concept + document property drawers Gustav Wikström
2019-09-01  5:20 ` Adam Porter [this message]
2019-09-01 10:38 ` Nicolas Goaziou
2019-09-01 14:41   ` Gustav Wikström
2019-09-06 20:09     ` Nicolas Goaziou
2019-09-29  9:39       ` Gustav Wikström
2019-09-01 15:25 ` Gustav Wikström
2019-09-01 16:11   ` Adam Porter
  -- strict thread matches above, loose matches on Subject: below --
2019-09-01 16:08 Gustav Wikström
2019-09-01 16:26 ` Adam Porter
2019-09-01 18:51 Gustav Wikström
2019-09-01 19:12 Gustav Wikström
2019-09-01 19:17 Gustav Wikström

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87blw4lhhr.fsf@alphapapa.net \
    --to=adam@alphapapa.net \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).