From: Ihor Radchenko <firstname.lastname@example.org> To: Allen Li <email@example.com> Cc: firstname.lastname@example.org Subject: Re: [BUG] ob-tangle overrides user customization of org-id-link-to-org-use-id [9.5.2 (9.5.2-gfbff08 @ /home/ionasal/.emacs.d/elpa/org-9.5.2/)] Date: Sun, 30 Jan 2022 16:56:05 +0800 [thread overview] Message-ID: <87bkztd2l6.fsf@localhost> (raw) In-Reply-To: <email@example.com> Allen Li <firstname.lastname@example.org> writes: >> If someone is willing to check all the occurrences of >> (defvar +[^ ]+ +nil) and remove nil values where we merely put a defvar >> to silence byte-compiler, please do it. > > My initial request was just to fix this one instance that is actively > troubling me. If there are any other known cases of defvar, they should > also be fixed. If not, then let's wait until someone identifies them. > > If any maintainers reading this could fix this one defvar, that'd be > great. I just pushed the fix onto bugfix as dd6486a07. Most of the occurrences of (defvar foo nil) in Org are just actual variable definitions without docstring (which is not good, but not an error). Also, I only skimmed through org-agenda.el. I am afraid to touch that monster even though most of such defvars are in org-agenda.el Best, Ihor
prev parent reply other threads:[~2022-01-30 8:51 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-01-11 11:03 Allen Li 2022-01-11 11:42 ` Ihor Radchenko 2022-01-11 18:53 ` Allen Li 2022-01-12 14:41 ` Ihor Radchenko 2022-01-13 7:43 ` Allen Li 2022-01-14 2:19 ` Ihor Radchenko 2022-01-14 9:50 ` Allen Li 2022-01-15 12:00 ` Ihor Radchenko 2022-01-25 5:20 ` Allen Li 2022-01-30 8:56 ` Ihor Radchenko [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://www.orgmode.org/ * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=87bkztd2l6.fsf@localhost \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [BUG] ob-tangle overrides user customization of org-id-link-to-org-use-id [9.5.2 (9.5.2-gfbff08 @ /home/ionasal/.emacs.d/elpa/org-9.5.2/)]' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).