From: Ihor Radchenko <email@example.com> To: Allen Li <firstname.lastname@example.org> Cc: email@example.com Subject: Re: [BUG] ob-tangle overrides user customization of org-id-link-to-org-use-id [9.5.2 (9.5.2-gfbff08 @ /home/ionasal/.emacs.d/elpa/org-9.5.2/)] Date: Sat, 15 Jan 2022 20:00:48 +0800 [thread overview] Message-ID: <871r19ryxb.fsf@localhost> (raw) In-Reply-To: <firstname.lastname@example.org> Allen Li <email@example.com> writes: > I see. In my opinion those occurrences should be fixed even if no one > is reporting issues because it is bad/improper code, and it is not > especially surprising that no one has reported it yet; there is always a > first person who reports a bug, and there are always more old bugs to be > found in a big project like Emacs/Org mode. > > This is annoying to reproduce because it relies on the normal Emacs > startup process, which loads packages. Anyway, I have found a reproduction. > > ... > 3. Press RET on the customize link. > > Note that the Customize UI says "CHANGED outside Customize." I was also able to reproduce the problem following your steps. Thank you! Unfortunately, fixing the occurrences of (defvar foo nil) is not completely straightforward. Some of them are real defvars. If someone is willing to check all the occurrences of (defvar +[^ ]+ +nil) and remove nil values where we merely put a defvar to silence byte-compiler, please do it. Also, I feel that my Elisp-foo is not good enough in this specific scenario. I invite others to reply if they feel that changing (defvar foo nil) to (defvar foo) for externally defined variables is _not_ universally safe. Best, Ihor
next prev parent reply other threads:[~2022-01-15 11:57 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-01-11 11:03 Allen Li 2022-01-11 11:42 ` Ihor Radchenko 2022-01-11 18:53 ` Allen Li 2022-01-12 14:41 ` Ihor Radchenko 2022-01-13 7:43 ` Allen Li 2022-01-14 2:19 ` Ihor Radchenko 2022-01-14 9:50 ` Allen Li 2022-01-15 12:00 ` Ihor Radchenko [this message] 2022-01-25 5:20 ` Allen Li 2022-01-30 8:56 ` Ihor Radchenko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://www.orgmode.org/ * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=871r19ryxb.fsf@localhost \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [BUG] ob-tangle overrides user customization of org-id-link-to-org-use-id [9.5.2 (9.5.2-gfbff08 @ /home/ionasal/.emacs.d/elpa/org-9.5.2/)]' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).