emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* org-special-keyword face not showing in sublevels anymore since commit 69700e1
@ 2014-06-30 16:59 Martin Carlé
  2014-07-25 14:52 ` Sebastien Vauban
  0 siblings, 1 reply; 7+ messages in thread
From: Martin Carlé @ 2014-06-30 16:59 UTC (permalink / raw)
  To: emacs-orgmode

[-- Attachment #1: Type: text/plain, Size: 412 bytes --]

It appears that by commit 69700e1 [22.04.2014 13:09] a little bug
slipped into the codebase, sinc the org-special-keyword face is only
shown at the top level in the correct face, but then gets simply
overwritten by the respective sublevel face. 

I guess, this is not intented and would be nice to have it fixed.

best,
mc

-- 
Fetch my gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 7E3CA33F


[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 805 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: org-special-keyword face not showing in sublevels anymore since commit 69700e1
  2014-06-30 16:59 org-special-keyword face not showing in sublevels anymore since commit 69700e1 Martin Carlé
@ 2014-07-25 14:52 ` Sebastien Vauban
  2014-07-28 12:49   ` mc
  0 siblings, 1 reply; 7+ messages in thread
From: Sebastien Vauban @ 2014-07-25 14:52 UTC (permalink / raw)
  To: emacs-orgmode-mXXj517/zsQ

Martin Carlé wrote:
> It appears that by commit 69700e1 [22.04.2014 13:09] a little bug
> slipped into the codebase, sinc the org-special-keyword face is only
> shown at the top level in the correct face, but then gets simply
> overwritten by the respective sublevel face. 

I did not understand exactly what you meant by sublevel face. Could you
explain more accurately, maybe with an ECM and a screenshot of how it
was before and after the above commit?

Best regards,
  Seb

-- 
Sebastien Vauban

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: org-special-keyword face not showing in sublevels anymore since commit 69700e1
  2014-07-25 14:52 ` Sebastien Vauban
@ 2014-07-28 12:49   ` mc
  2014-07-28 14:04     ` Bastien
  0 siblings, 1 reply; 7+ messages in thread
From: mc @ 2014-07-28 12:49 UTC (permalink / raw)
  To: Sebastien Vauban; +Cc: emacs-orgmode

[-- Attachment #1: Type: text/plain, Size: 556 bytes --]

Hello Seb, 

nice that you come back to this issue.

I don’t know what “an ECM” is, but I attach you a simple org file and two screenshots that exemplify the case. 

1st screenshot
    org-special-keyword_face_example_after_commit_69700e1.png
shows all ‘COMMENT’ keywords correctly rendered by the org-special-keyword face as colour grey. 

2nd screenshot 
     org-special-keyword_face_example_after_commit_69700e1.png
shows all ‘COMMENT’ keywords as grey only at the top outline level. 

I hope this clarifies the case.

All best,
mc


[-- Attachment #2: org-special-keyword_face_example.org --]
[-- Type: application/octet-stream, Size: 271 bytes --]

* COMMENT top level -> keyword 'COMMENT' is shown by org-special-keyword face (grey in this case)
** COMMENT second level -> keyword 'COMMENT' is NOT shown by org-special-keyword face
*** COMMENT third level ->  keyword 'COMMENT' is NOT shown by org-special-keyword face

[-- Attachment #3: org-special-keyword_face_example_before_commit_69700e1.png --]
[-- Type: image/png, Size: 17496 bytes --]

[-- Attachment #4: Type: text/plain, Size: 1 bytes --]



[-- Attachment #5: org-special-keyword_face_example_after_commit_69700e1.png --]
[-- Type: image/png, Size: 17089 bytes --]

[-- Attachment #6: Type: text/plain, Size: 630 bytes --]


On 25 Jul 2014, at 17:52, Sebastien Vauban <sva-news@mygooglest.com> wrote:

> Martin Carlé wrote:
>> It appears that by commit 69700e1 [22.04.2014 13:09] a little bug
>> slipped into the codebase, sinc the org-special-keyword face is only
>> shown at the top level in the correct face, but then gets simply
>> overwritten by the respective sublevel face. 
> 
> I did not understand exactly what you meant by sublevel face. Could you
> explain more accurately, maybe with an ECM and a screenshot of how it
> was before and after the above commit?
> 
> Best regards,
>  Seb
> 
> -- 
> Sebastien Vauban
> 
> 


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: org-special-keyword face not showing in sublevels anymore since commit 69700e1
  2014-07-28 12:49   ` mc
@ 2014-07-28 14:04     ` Bastien
  2014-07-29 11:43       ` hiding intrusive target-markups-brackets ++ " mc
  0 siblings, 1 reply; 7+ messages in thread
From: Bastien @ 2014-07-28 14:04 UTC (permalink / raw)
  To: mc; +Cc: Sebastien Vauban, emacs-orgmode

Hi Martin,

mc <mc@aiguphonie.com> writes:

> 2nd screenshot 
>      org-special-keyword_face_example_after_commit_69700e1.png
> shows all ‘COMMENT’ keywords as grey only at the top outline level. 
>
> I hope this clarifies the case.

Yes it does!  This is now fixed, thanks,

-- 
 Bastien

^ permalink raw reply	[flat|nested] 7+ messages in thread

* hiding intrusive target-markups-brackets ++ Re: org-special-keyword face not showing in sublevels anymore since commit 69700e1
  2014-07-28 14:04     ` Bastien
@ 2014-07-29 11:43       ` mc
  2014-07-29 15:18         ` Bastien
  0 siblings, 1 reply; 7+ messages in thread
From: mc @ 2014-07-29 11:43 UTC (permalink / raw)
  To: Bastien; +Cc: emacs-orgmode

Hello again Bastien,

thanx for the fix!

Please allow me to shortly direct your attention to an open, 
still uncommented 'feature request’ addressing an optional
‘fontification' or ‘hiding' of the some kind of intrusive target-markups-brackets ( <<  >> ), 
just like this is done with the org-link brackets ( [[ ]] ).

The first reference that was expressing this desire, I found here:

http://lists.gnu.org/archive/html/emacs-orgmode/2010-03/msg00379.html

Or could there be posted some hint how to best hack this as a private solution?

All best,
mc

On 28 Jul 2014, at 17:04, Bastien <bzg@gnu.org> wrote:

> Hi Martin,
> 
> mc <mc@aiguphonie.com> writes:
> 
>> 2nd screenshot 
>>     org-special-keyword_face_example_after_commit_69700e1.png
>> shows all ‘COMMENT’ keywords as grey only at the top outline level. 
>> 
>> I hope this clarifies the case.
> 
> Yes it does!  This is now fixed, thanks,
> 
> -- 
> Bastien

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: hiding intrusive target-markups-brackets ++ Re: org-special-keyword face not showing in sublevels anymore since commit 69700e1
  2014-07-29 11:43       ` hiding intrusive target-markups-brackets ++ " mc
@ 2014-07-29 15:18         ` Bastien
  2014-08-04 11:23           ` Gaston Tridoulos
  0 siblings, 1 reply; 7+ messages in thread
From: Bastien @ 2014-07-29 15:18 UTC (permalink / raw)
  To: mc; +Cc: emacs-orgmode

Hi,

mc <mc@aiguphonie.com> writes:

> Please allow me to shortly direct your attention to an open, 
> still uncommented 'feature request’ addressing an optional
> ‘fontification' or ‘hiding' of the some kind of intrusive target-markups-brackets ( <<  >> ), 
> just like this is done with the org-link brackets ( [[ ]] ).

I agree this would be useful, I gave it a try at the time but could
not finish the code.  I will have a look again at the end of august.

Don't hesitate to raise this up again in september if nothing happens.

Thanks,

-- 
 Bastien

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: hiding intrusive target-markups-brackets ++ Re: org-special-keyword face not showing in sublevels anymore since commit 69700e1
  2014-07-29 15:18         ` Bastien
@ 2014-08-04 11:23           ` Gaston Tridoulos
  0 siblings, 0 replies; 7+ messages in thread
From: Gaston Tridoulos @ 2014-08-04 11:23 UTC (permalink / raw)
  To: emacs-orgmode

Bastien <bzg <at> gnu.org> writes:

> 
> Hi,
> 
> mc <mc <at> aiguphonie.com> writes:
> 
> > Please allow me to shortly direct your attention to an open, 
> > still uncommented 'feature request’ addressing an optional
> > ‘fontification' or ‘hiding' of the some kind of intrusive
target-markups-brackets ( <<  >> ), 
> > just like this is done with the org-link brackets ( [[ ]] ).
> 
> I agree this would be useful, I gave it a try at the time but could
> not finish the code.  I will have a look again at the end of august.
> 
> Don't hesitate to raise this up again in september if nothing happens.
> 
> Thanks,

Bastien,

thank you very much indeed for looking into this! I was also wondering if it
was possible to hide the brackets and I fully second Martin's request. radio
links become a lot more useful with this reduction of clutter in the file. 

Best

Gaston

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2014-08-04 11:25 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-06-30 16:59 org-special-keyword face not showing in sublevels anymore since commit 69700e1 Martin Carlé
2014-07-25 14:52 ` Sebastien Vauban
2014-07-28 12:49   ` mc
2014-07-28 14:04     ` Bastien
2014-07-29 11:43       ` hiding intrusive target-markups-brackets ++ " mc
2014-07-29 15:18         ` Bastien
2014-08-04 11:23           ` Gaston Tridoulos

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).