* Bug: Non buffer-local org-not-done-heading-regexp breaks TODO dependencies under certain circumstances [8.3beta (release_8.3beta-1178-g317886 @ /opt/local/share/emacs/site-lisp/org/)]
@ 2015-05-29 21:10 Alexander Borkowski
2015-05-29 22:09 ` Nicolas Goaziou
0 siblings, 1 reply; 2+ messages in thread
From: Alexander Borkowski @ 2015-05-29 21:10 UTC (permalink / raw)
To: emacs-orgmode
Hi all,
I experimented a bit with per-file TODO keywords and noticed that
under certain circumstances TODO dependencies are broken. A minimal
example to reproduce the problem I encountered (under emacs -q)
would be as follows:
- Enable TODO dependencies, i.e. eval
(setq org-enforce-todo-dependencies t)
in *scratch*.
- Create one file (e.g. "~/test-local.org") with these contents:
#+TODO: LOCALTODO | LOCALDONE
* Local Parent
:PROPERTIES:
:ORDERED: t
:END:
** LOCALTODO First
** LOCALTODO Second
Then add it to the end of agenda-files (with C-u C-c [) and close the buffer.
- Create another file (e.g. "~/test-global.org") with these contents:
* Global Parent
:PROPERTIES:
:ORDERED: t
:END:
** TODO First
** TODO Second
Then also add it to the end of agenda-files (with C-u C-c [) and close the buffer.
- Now view the global TODO list (M-x org-todo-list) and notice that the second
TODO from the "local" file is not dimmed and it is possible to change its TODO
state (using the t key) as it is not blocked, but should be.
I did some tracking down and I think this comes from the fact that variable
org-not-done-heading-regexp is not buffer-local. It probably should be as both
lines 4800 and 4803 in org.el are:
(make-variable-buffer-local 'org-not-done-regexp)
When I re-open emacs and eval (what I suspect line 4803 should be)
(make-variable-buffer-local 'org-not-done-heading-regexp)
in *scratch* before re-runing the above steps everything works as expected.
Regards,
Alex B.
Emacs : GNU Emacs 24.5.1 (x86_64-apple-darwin11.4.2)
of 2015-04-14 on tenseven-slave.macports.org
Package: Org-mode version 8.3beta (release_8.3beta-1178-g317886 @ /opt/local/share/emacs/site-lisp/org/)
current state:
==============
(setq
org-tab-first-hook '(org-hide-block-toggle-maybe org-babel-hide-result-toggle-maybe
org-babel-header-arg-expand)
org-speed-command-hook '(org-speed-command-default-hook org-babel-speed-command-hook)
org-occur-hook '(org-first-headline-recenter)
org-metaup-hook '(org-babel-load-in-session-maybe)
org-confirm-shell-link-function 'yes-or-no-p
org-after-todo-state-change-hook '(org-clock-out-if-current)
org-src-mode-hook '(org-src-babel-configure-edit-buffer org-src-mode-configure-edit-buffer)
org-agenda-before-write-hook '(org-agenda-add-entry-text)
org-babel-pre-tangle-hook '(save-buffer)
org-mode-hook '(#[nil "\300\301\302\303\304$\207"
[org-add-hook change-major-mode-hook org-show-block-all append local] 5]
#[nil "\300\301\302\303\304$\207"
[org-add-hook change-major-mode-hook org-babel-show-result-all append local]
5]
org-babel-result-hide-spec org-babel-hide-all-hashes)
org-archive-hook '(org-attach-archive-delete-maybe)
org-ctrl-c-ctrl-c-hook '(org-babel-hash-at-point org-babel-execute-safely-maybe)
org-enforce-todo-dependencies t
org-cycle-hook '(org-cycle-hide-archived-subtrees org-cycle-hide-drawers
org-cycle-show-empty-lines org-optimize-window-after-visibility-change)
org-confirm-elisp-link-function 'yes-or-no-p
org-metadown-hook '(org-babel-pop-to-session-maybe)
org-blocker-hook '(org-block-todo-from-children-or-siblings-or-parent)
org-agenda-files '("~/test-local.org" "~/test-global.org")
org-clock-out-hook '(org-clock-remove-empty-clock-drawer)
)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Bug: Non buffer-local org-not-done-heading-regexp breaks TODO dependencies under certain circumstances [8.3beta (release_8.3beta-1178-g317886 @ /opt/local/share/emacs/site-lisp/org/)]
2015-05-29 21:10 Bug: Non buffer-local org-not-done-heading-regexp breaks TODO dependencies under certain circumstances [8.3beta (release_8.3beta-1178-g317886 @ /opt/local/share/emacs/site-lisp/org/)] Alexander Borkowski
@ 2015-05-29 22:09 ` Nicolas Goaziou
0 siblings, 0 replies; 2+ messages in thread
From: Nicolas Goaziou @ 2015-05-29 22:09 UTC (permalink / raw)
To: Alexander Borkowski; +Cc: emacs-orgmode
Hello,
Alexander Borkowski <alex-b@opus-b.com> writes:
> I did some tracking down and I think this comes from the fact that variable
> org-not-done-heading-regexp is not buffer-local. It probably should be as both
> lines 4800 and 4803 in org.el are:
>
> (make-variable-buffer-local 'org-not-done-regexp)
Good catch. That's a typo.
Fixed in d00dcd09ca64f8d653241c1462b4e0d05ca92c73. Thank you.
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-05-29 22:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-05-29 21:10 Bug: Non buffer-local org-not-done-heading-regexp breaks TODO dependencies under certain circumstances [8.3beta (release_8.3beta-1178-g317886 @ /opt/local/share/emacs/site-lisp/org/)] Alexander Borkowski
2015-05-29 22:09 ` Nicolas Goaziou
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).