* Status line change?
@ 2017-06-22 23:39 Russell Adams
2017-06-23 0:27 ` Kyle Meyer
0 siblings, 1 reply; 5+ messages in thread
From: Russell Adams @ 2017-06-22 23:39 UTC (permalink / raw)
To: emacs-orgmode
Since I recently upgraded my Org from an ancient v7 to 9.0.5, I noticed that when I use C-c C-t to change a headline to
DONE that I no longer see a message on the status bar indicating it was changed. The lack of feedback makes me often go
up to the headline to confirm that it changed.
I couldn't find a customization item through a casual search.
Can anyone tell me how to enable that behavior again? Getting feedback on the headline state change is important.
Thanks.
------------------------------------------------------------------
Russell Adams RLAdams@AdamsInfoServ.com
PGP Key ID: 0x1160DCB3 http://www.adamsinfoserv.com/
Fingerprint: 1723 D8CA 4280 1EC9 557F 66E8 1154 E018 1160 DCB3
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Status line change?
2017-06-22 23:39 Status line change? Russell Adams
@ 2017-06-23 0:27 ` Kyle Meyer
2017-06-23 0:53 ` Russell Adams
0 siblings, 1 reply; 5+ messages in thread
From: Kyle Meyer @ 2017-06-23 0:27 UTC (permalink / raw)
To: Russell Adams, emacs-orgmode
Russell Adams <RLAdams@AdamsInfoServ.Com> writes:
> Since I recently upgraded my Org from an ancient v7 to 9.0.5, I noticed that when I use C-c C-t to change a headline to
> DONE that I no longer see a message on the status bar indicating it was changed. The lack of feedback makes me often go
> up to the headline to confirm that it changed.
Testing with 9.0.5 and 9.0.9, I see a "TODO state changed to DONE"
message in the echo area, which I think is what you're referring to.
Not sure what the issue would be. You could check if you see the
message in your *Messages* buffer. If you do, then a subsequent message
is may be masking it. You could also debug org-todo to verify that the
"(message "TODO state changed to %s" (org-trim next))" line is being
executed.
--
Kyle
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Status line change?
2017-06-23 0:27 ` Kyle Meyer
@ 2017-06-23 0:53 ` Russell Adams
2017-06-23 1:16 ` Kyle Meyer
0 siblings, 1 reply; 5+ messages in thread
From: Russell Adams @ 2017-06-23 0:53 UTC (permalink / raw)
To: emacs-orgmode
On Thu, Jun 22, 2017 at 08:27:41PM -0400, Kyle Meyer wrote:
> Russell Adams <RLAdams@AdamsInfoServ.Com> writes:
>
> > Since I recently upgraded my Org from an ancient v7 to 9.0.5, I noticed that when I use C-c C-t to change a headline to
> > DONE that I no longer see a message on the status bar indicating it was changed. The lack of feedback makes me often go
> > up to the headline to confirm that it changed.
>
> Testing with 9.0.5 and 9.0.9, I see a "TODO state changed to DONE"
> message in the echo area, which I think is what you're referring to.
> Not sure what the issue would be. You could check if you see the
> message in your *Messages* buffer. If you do, then a subsequent message
> is may be masking it. You could also debug org-todo to verify that the
> "(message "TODO state changed to %s" (org-trim next))" line is being
> executed.
I just tested it again, and the key is if the headline is on the screen I see a status message. If the headline is off
screen there is no update on the status line. That's why it's an annoyance, I have to scroll back several screens to
confirm it changes to DONE.
------------------------------------------------------------------
Russell Adams RLAdams@AdamsInfoServ.com
PGP Key ID: 0x1160DCB3 http://www.adamsinfoserv.com/
Fingerprint: 1723 D8CA 4280 1EC9 557F 66E8 1154 E018 1160 DCB3
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Status line change?
2017-06-23 0:53 ` Russell Adams
@ 2017-06-23 1:16 ` Kyle Meyer
2017-06-23 1:36 ` Kyle Meyer
0 siblings, 1 reply; 5+ messages in thread
From: Kyle Meyer @ 2017-06-23 1:16 UTC (permalink / raw)
To: Russell Adams, emacs-orgmode
Russell Adams <RLAdams@AdamsInfoServ.Com> writes:
> On Thu, Jun 22, 2017 at 08:27:41PM -0400, Kyle Meyer wrote:
>> Testing with 9.0.5 and 9.0.9, I see a "TODO state changed to DONE"
>> message in the echo area, which I think is what you're referring to.
>> Not sure what the issue would be. You could check if you see the
>> message in your *Messages* buffer. If you do, then a subsequent message
>> is may be masking it. You could also debug org-todo to verify that the
>> "(message "TODO state changed to %s" (org-trim next))" line is being
>> executed.
>
> I just tested it again, and the key is if the headline is on the screen I see a status message. If the headline is off
> screen there is no update on the status line. That's why it's an annoyance, I have to scroll back several screens to
> confirm it changes to DONE.
I see. With the headline off the screen, I can reproduce this. I've
bisected it down to dd17e9d29 (org.el (org-todo): When changing from one
state to the same state, throw a more accurate message, 2014-05-31).
That change seems to have unintentionally reversed the visibility check,
which should be
-- >8 --
diff --git a/lisp/org.el b/lisp/org.el
index 1e6d00973..d9b6489ff 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -12681,7 +12681,7 @@ (defun org-todo (&optional arg)
(replace-match next t t)
(cond ((equal this org-state)
(message "TODO state was already %s" (org-trim next)))
- ((pos-visible-in-window-p hl-pos)
+ ((not (pos-visible-in-window-p hl-pos))
(message "TODO state changed to %s" (org-trim next))))
(unless head
(setq head (org-get-todo-sequence-head org-state)
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: Status line change?
2017-06-23 1:16 ` Kyle Meyer
@ 2017-06-23 1:36 ` Kyle Meyer
0 siblings, 0 replies; 5+ messages in thread
From: Kyle Meyer @ 2017-06-23 1:36 UTC (permalink / raw)
To: Russell Adams, emacs-orgmode
Kyle Meyer <kyle@kyleam.com> writes:
> That change seems to have unintentionally reversed the visibility check,
> which should be
>
> -- >8 --
> diff --git a/lisp/org.el b/lisp/org.el
> index 1e6d00973..d9b6489ff 100644
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -12681,7 +12681,7 @@ (defun org-todo (&optional arg)
> (replace-match next t t)
> (cond ((equal this org-state)
> (message "TODO state was already %s" (org-trim next)))
> - ((pos-visible-in-window-p hl-pos)
> + ((not (pos-visible-in-window-p hl-pos))
> (message "TODO state changed to %s" (org-trim next))))
> (unless head
> (setq head (org-get-todo-sequence-head org-state)
Pushed (1930a8f05ac3c09b6366491c076a3efde2f2205d).
--
Kyle
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-06-23 1:36 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-22 23:39 Status line change? Russell Adams
2017-06-23 0:27 ` Kyle Meyer
2017-06-23 0:53 ` Russell Adams
2017-06-23 1:16 ` Kyle Meyer
2017-06-23 1:36 ` Kyle Meyer
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).