From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Jay Kamat <jaygkamat@gmail.com>
Cc: emacs-orgmode@gnu.org, "Charles C. Berry" <ccberry@ucsd.edu>
Subject: Re: [PATCH] Support for 'using namespace *' in ob-C.el
Date: Tue, 01 Aug 2017 18:48:06 +0200 [thread overview]
Message-ID: <87a83js08p.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <CACe_Yv_L1E7c2enXdiNu5kRrMjGrG55xyPU636qxjsTMqzMo-g@mail.gmail.com> (Jay Kamat's message of "Mon, 31 Jul 2017 22:54:57 -0700")
Jay Kamat <jaygkamat@gmail.com> writes:
> Hi Chuck,
>
> Thanks for pointing that out, this all makes a lot more sense now.
> Prior to this patch ':includes' and ':defines' seem to work in the
> property list (as described in the old version of the org manual), so
> (I think) the updated version of this patch also removes those usages
> (for :defines, :includes), so you must use the new format described in
> the manual.
>
> Speaking of the manual, that entry managed to get me very confused at
> first, as it didn't seem to work for me, but then I realized that
> there is actually a typo in the NEWS entry, the second line should be:
>
> :header-args+: :var a=1 b=2
>
> I'm not sure what the policy is on changing old NEWS entries, but I've
> attached a small patch to fix the typo.
>
> Let me know if you have any other feedback! :)
>
> -Jay
>
>
> On Mon, Jul 31, 2017 at 8:34 AM, Charles C. Berry <ccberry@ucsd.edu> wrote:
>> On Mon, 31 Jul 2017, Jay Kamat wrote:
>>
>>> Hello!
>>>
>>> Sorry for the late reply, I was pretty busy last week. An updated
>>> patch is attached!
>>>
>>
>> [snip]
>>
>>>
>>>> Using `org-entry-get' is no longer supported. You can replace the `or'
>>>> with
>>>>
>>>> (cdr (assq :namespaces params))
>>>
>>>
>>> Done, I also replaced the other uses of 'org-entry-get' around the one
>>> I modified
>>>
>>
>> I don't think Nicolas meant that `org-entry-get' is no longer supported
>> literally. I think he was referring to using it to enable using Babel header
>> arguments as property names (as it did in your code). See:
>>
>> http://orgmode.org/Changes.html#org343de47
>>
>>
>> HTH,
>>
>> Chuck
>
>
--
Nicolas Goaziou
next prev parent reply other threads:[~2017-08-01 16:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-17 5:31 [PATCH] Support for 'using namespace *' in ob-C.el Jay Kamat
2017-07-23 14:44 ` Nicolas Goaziou
2017-07-31 8:03 ` Jay Kamat
2017-07-31 15:34 ` Charles C. Berry
2017-08-01 5:54 ` Jay Kamat
2017-08-01 16:48 ` Nicolas Goaziou [this message]
2017-08-01 16:48 ` Nicolas Goaziou
2017-08-02 1:40 ` Jay Kamat
2017-08-02 6:49 ` Nicolas Goaziou
2017-08-01 8:22 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a83js08p.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=ccberry@ucsd.edu \
--cc=emacs-orgmode@gnu.org \
--cc=jaygkamat@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).