From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: [PATCH] Support for 'using namespace *' in ob-C.el Date: Tue, 01 Aug 2017 18:48:06 +0200 Message-ID: <87a83js08p.fsf@nicolasgoaziou.fr> References: <874lu3mcw7.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:45989) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dcaL5-0004ps-MF for emacs-orgmode@gnu.org; Tue, 01 Aug 2017 12:48:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dcaL4-0006Ep-Jx for emacs-orgmode@gnu.org; Tue, 01 Aug 2017 12:48:11 -0400 Received: from relay3-d.mail.gandi.net ([2001:4b98:c:538::195]:48660) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dcaL4-0006EO-D0 for emacs-orgmode@gnu.org; Tue, 01 Aug 2017 12:48:10 -0400 In-Reply-To: (Jay Kamat's message of "Mon, 31 Jul 2017 22:54:57 -0700") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Jay Kamat Cc: emacs-orgmode@gnu.org, "Charles C. Berry" Jay Kamat writes: > Hi Chuck, > > Thanks for pointing that out, this all makes a lot more sense now. > Prior to this patch ':includes' and ':defines' seem to work in the > property list (as described in the old version of the org manual), so > (I think) the updated version of this patch also removes those usages > (for :defines, :includes), so you must use the new format described in > the manual. > > Speaking of the manual, that entry managed to get me very confused at > first, as it didn't seem to work for me, but then I realized that > there is actually a typo in the NEWS entry, the second line should be: > > :header-args+: :var a=1 b=2 > > I'm not sure what the policy is on changing old NEWS entries, but I've > attached a small patch to fix the typo. > > Let me know if you have any other feedback! :) > > -Jay > > > On Mon, Jul 31, 2017 at 8:34 AM, Charles C. Berry wrote: >> On Mon, 31 Jul 2017, Jay Kamat wrote: >> >>> Hello! >>> >>> Sorry for the late reply, I was pretty busy last week. An updated >>> patch is attached! >>> >> >> [snip] >> >>> >>>> Using `org-entry-get' is no longer supported. You can replace the `or' >>>> with >>>> >>>> (cdr (assq :namespaces params)) >>> >>> >>> Done, I also replaced the other uses of 'org-entry-get' around the one >>> I modified >>> >> >> I don't think Nicolas meant that `org-entry-get' is no longer supported >> literally. I think he was referring to using it to enable using Babel header >> arguments as property names (as it did in your code). See: >> >> http://orgmode.org/Changes.html#org343de47 >> >> >> HTH, >> >> Chuck > > -- Nicolas Goaziou