From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Carlos Pita <carlosjosepita@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: Bug: Add option to fontify latex blocks [9.1.9 (release_9.1.9-65-g5e4542 @ /home/carlos/local/stow/emacs-26/share/emacs/26.1.50/lisp/org/)]
Date: Tue, 01 Jan 2019 17:46:26 +0100 [thread overview]
Message-ID: <87a7kkz5p9.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <CAELgYhdcW1XnR7BTmos6vAF_YPJ4Wdp=3FEAhBEYfeA4B2nvSw@mail.gmail.com> (Carlos Pita's message of "Sat, 22 Dec 2018 12:07:08 -0300")
Hello,
Carlos Pita <carlosjosepita@gmail.com> writes:
> Here is a patch on top of latest revision. It just adds an extension
> function while initializing font locking, as documented in [1]. It
> indeed reduces lines of code to some extent by moving the dirty stuff
> out of the fontification function (but I tried to keep the code
> formatting of your last commit, since it was rather different than the
> one shipped with emacs). The approach is more robust AFAICS since the
> font locking framework is correctly informed of which blocks should be
> refontified before fontification itself happens. It covers all types
> of blocks: #+BEGIN/#+END, \begin\end, \[\]. It's not a full parser but
> at least it matches corresponding delimiters by type by using a simple
> heuristic.
I still think it is not a good long-term solution for fontification. I'd
rather see work to integrate fontification with the parser.
Meanwhile, I applied your patch in master. I also added a commit
message.
Thank you.
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2019-01-01 16:46 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-27 22:32 Bug: Add option to fontify latex blocks [9.1.9 (release_9.1.9-65-g5e4542 @ /home/carlos/local/stow/emacs-26/share/emacs/26.1.50/lisp/org/)] Carlos Pita
2018-11-27 22:58 ` Carlos Pita
2018-11-27 23:49 ` Nicolas Goaziou
2018-11-28 0:14 ` Carlos Pita
2018-11-28 0:27 ` Carlos Pita
2018-11-28 1:22 ` Carlos Pita
2018-11-28 10:57 ` Nicolas Goaziou
2018-11-28 15:02 ` Carlos Pita
2018-11-28 16:55 ` Carlos Pita
2018-11-28 17:28 ` Carlos Pita
2018-11-28 18:38 ` Carlos Pita
2018-11-28 22:46 ` Carlos Pita
2018-12-03 3:54 ` Carlos Pita
2018-12-03 4:18 ` Carlos Pita
2018-12-19 21:42 ` Nicolas Goaziou
2018-12-21 23:37 ` Carlos Pita
2018-12-21 23:54 ` Carlos Pita
2018-12-22 0:42 ` Carlos Pita
2018-12-22 0:46 ` Carlos Pita
2018-12-22 2:38 ` Carlos Pita
2018-12-22 8:21 ` Nicolas Goaziou
2018-12-22 13:16 ` Carlos Pita
2018-12-22 15:07 ` Carlos Pita
2019-01-01 16:46 ` Nicolas Goaziou [this message]
2019-01-01 17:11 ` Carlos Pita
2019-01-01 17:14 ` Carlos Pita
2019-01-01 18:17 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a7kkz5p9.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=carlosjosepita@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).