emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* [BUG] Cursor is moved after changing list bullets
@ 2022-06-14 13:16 Daniel Fleischer
  2022-06-14 13:30 ` Ihor Radchenko
  0 siblings, 1 reply; 4+ messages in thread
From: Daniel Fleischer @ 2022-06-14 13:16 UTC (permalink / raw)
  To: emacs-orgmode

Hi, there is a regression introduced in:

    ed6f8dc67 org-list: Do not move point and change space when
              promoting/demoting items

When calling `org-cycle-list-bullet' (e.g. using S-right or S-left) the
cursor moves to the beginning of the text after changing the bullet
type. It used to not move which is useful to when trying different
bullet styles. This is due to the changes in
`org-list-struct-apply-struct'. I tried to debug it but I'm not sure
what was the issue the patch was meant to solve.

Thanks, 

-- 

Daniel Fleischer


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [BUG] Cursor is moved after changing list bullets
  2022-06-14 13:16 [BUG] Cursor is moved after changing list bullets Daniel Fleischer
@ 2022-06-14 13:30 ` Ihor Radchenko
  2022-06-14 14:14   ` Daniel Fleischer
  0 siblings, 1 reply; 4+ messages in thread
From: Ihor Radchenko @ 2022-06-14 13:30 UTC (permalink / raw)
  To: Daniel Fleischer; +Cc: emacs-orgmode

Daniel Fleischer <danflscr@gmail.com> writes:

> Hi, there is a regression introduced in:
>
>     ed6f8dc67 org-list: Do not move point and change space when
>               promoting/demoting items
>
> When calling `org-cycle-list-bullet' (e.g. using S-right or S-left) the
> cursor moves to the beginning of the text after changing the bullet
> type. It used to not move which is useful to when trying different
> bullet styles. This is due to the changes in
> `org-list-struct-apply-struct'. I tried to debug it but I'm not sure
> what was the issue the patch was meant to solve.

I am unable to reproduce using any of the supported Emacs versions.
Could you please provide more concrete steps? Or better a test.

Best,
Ihor


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [BUG] Cursor is moved after changing list bullets
  2022-06-14 13:30 ` Ihor Radchenko
@ 2022-06-14 14:14   ` Daniel Fleischer
  2022-06-16 12:12     ` Ihor Radchenko
  0 siblings, 1 reply; 4+ messages in thread
From: Daniel Fleischer @ 2022-06-14 14:14 UTC (permalink / raw)
  To: Ihor Radchenko; +Cc: emacs-orgmode

Ihor Radchenko [2022-06-14 Tue 21:30] wrote:

> I am unable to reproduce using any of the supported Emacs versions.
> Could you please provide more concrete steps? Or better a test.

Create a file called `list.org` with the following:

    * Test

    - Hello.
    - hi.
    - bye.

Then call:

    emacs -Q -L ./Projects/org-mode/lisp/ -l org list.org

Then put the cursor on one of the hyphens and change its style using
S-right. The bullet will change and the cursor will move to the
beginning of a word instead of stay in place.

-- 

Daniel Fleischer


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [BUG] Cursor is moved after changing list bullets
  2022-06-14 14:14   ` Daniel Fleischer
@ 2022-06-16 12:12     ` Ihor Radchenko
  0 siblings, 0 replies; 4+ messages in thread
From: Ihor Radchenko @ 2022-06-16 12:12 UTC (permalink / raw)
  To: Daniel Fleischer; +Cc: emacs-orgmode

Daniel Fleischer <danflscr@gmail.com> writes:

> Ihor Radchenko [2022-06-14 Tue 21:30] wrote:
>
>> I am unable to reproduce using any of the supported Emacs versions.
>> Could you please provide more concrete steps? Or better a test.
>
> Create a file called `list.org` with the following:
> ...
> Then put the cursor on one of the hyphens...

Thanks! I missed the part that cursor should be on one of the hyphens.

Fixed via 707d3a093 on main.

Best,
Ihor


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-06-16 12:12 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-06-14 13:16 [BUG] Cursor is moved after changing list bullets Daniel Fleischer
2022-06-14 13:30 ` Ihor Radchenko
2022-06-14 14:14   ` Daniel Fleischer
2022-06-16 12:12     ` Ihor Radchenko

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).