emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: "Eric Schulte" <schulte.eric@gmail.com>
To: Vladimir Alexiev <vladimir@sirma.bg>
Cc: emacs-orgmode@gnu.org
Subject: Re: Re: [BUG] org-babel-tangle causes "Wrong type argument: sequencep, hline"
Date: Sun, 27 Feb 2011 17:19:10 -0700	[thread overview]
Message-ID: <878vx1yps1.fsf@gmail.com> (raw)
In-Reply-To: <loom.20110228T001635-912@post.gmane.org> (Vladimir Alexiev's message of "Sun, 27 Feb 2011 23:21:55 +0000 (UTC)")

Vladimir Alexiev <vladimir@sirma.bg> writes:

>> The hline was assumed to be a list (as normal rows are) by the indexing
>> code, so I just inserted a quick check to ensure that hlines are left
>> alone.
>
> So Eric, you're handing this arg as per documentation (info)
> * :hlines: `no' (default)
>   Strips horizontal lines from the input table.
>
> But you've missed handling this arg:
> * :colnames `nil' (default) 
>   If an input table looks like it has column names (because
>   its second row is an hline), then the column names will be removed
>   from the table before processing
>
> I think that org-babel-ref-index-list should receive the stripped table,
> i.e. these elements should have been removed:
>   ("search" "replace") hline
>

I see the point you are making, and this behavior would be ideal.
Unfortunately, the indices are applied to the variable during resolution
of the reference and at this time other header arguments, e.g., :hlines,
:colnames, and :rownames are not available to pre-process the table.

While not ideal, I do believe that it is consistent to say that the
index is applied to the table *before* the other table related header
arguments are applied.  I will update the documentation to make this
clear.

Best -- Eric

next prev parent reply	other threads:[~2011-02-28  0:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-27 13:57 [BUG] org-babel-tangle causes "Wrong type argument: sequencep, hline" Vladimir Alexiev
2011-02-27 16:06 ` Eric Schulte
2011-02-27 20:07   ` Sébastien Vauban
2011-02-27 21:19     ` Eric Schulte
2011-02-27 22:41       ` Sébastien Vauban
2011-02-27 23:21       ` Vladimir Alexiev
2011-02-28  0:19         ` Eric Schulte [this message]
2011-02-28  0:58           ` [BUG] org-babel-tangle causes Vladimir Alexiev
2011-02-28  4:03             ` Eric Schulte

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878vx1yps1.fsf@gmail.com \
    --to=schulte.eric@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=vladimir@sirma.bg \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).