From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Eric Schulte" Subject: Re: Re: [BUG] org-babel-tangle causes "Wrong type argument: sequencep, hline" Date: Sun, 27 Feb 2011 17:19:10 -0700 Message-ID: <878vx1yps1.fsf@gmail.com> References: <87zkpha2de.fsf@gmail.com> <8039n9nswf.fsf@somewhere.org> <87zkph89b3.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from [140.186.70.92] (port=58785 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ptqpb-0007dq-JQ for emacs-orgmode@gnu.org; Sun, 27 Feb 2011 19:19:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ptqpa-0007qj-Ne for emacs-orgmode@gnu.org; Sun, 27 Feb 2011 19:19:19 -0500 Received: from mail-yi0-f41.google.com ([209.85.218.41]:49181) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ptqpa-0007qa-G8 for emacs-orgmode@gnu.org; Sun, 27 Feb 2011 19:19:18 -0500 Received: by yib2 with SMTP id 2so1733373yib.0 for ; Sun, 27 Feb 2011 16:19:17 -0800 (PST) In-Reply-To: (Vladimir Alexiev's message of "Sun, 27 Feb 2011 23:21:55 +0000 (UTC)") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Vladimir Alexiev Cc: emacs-orgmode@gnu.org Vladimir Alexiev writes: >> The hline was assumed to be a list (as normal rows are) by the indexing >> code, so I just inserted a quick check to ensure that hlines are left >> alone. > > So Eric, you're handing this arg as per documentation (info) > * :hlines: `no' (default) > Strips horizontal lines from the input table. > > But you've missed handling this arg: > * :colnames `nil' (default) > If an input table looks like it has column names (because > its second row is an hline), then the column names will be removed > from the table before processing > > I think that org-babel-ref-index-list should receive the stripped table, > i.e. these elements should have been removed: > ("search" "replace") hline > I see the point you are making, and this behavior would be ideal. Unfortunately, the indices are applied to the variable during resolution of the reference and at this time other header arguments, e.g., :hlines, :colnames, and :rownames are not available to pre-process the table. While not ideal, I do believe that it is consistent to say that the index is applied to the table *before* the other table related header arguments are applied. I will update the documentation to make this clear. Best -- Eric