From: Nicolas Goaziou <n.goaziou@gmail.com>
To: Tassilo Horn <tassilo@member.fsf.org>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Fix renumbering for footnotes at BOL.
Date: Thu, 29 Sep 2011 13:41:05 +0200 [thread overview]
Message-ID: <877h4rh8z2.fsf@gmail.com> (raw)
In-Reply-To: <87ehyzk8n5.fsf@thinkpad.tsdh.de> (Tassilo Horn's message of "Thu, 29 Sep 2011 11:19:58 +0200")
Hello,
Tassilo Horn <tassilo@member.fsf.org> writes:
> org-footnote-renumber-fn:N invalidates footnotes that appear as the
> first thing on a line. Here's a test file including the recipe.
>
> * Bla
>
> This is a line in which the following footnote that is inserted exactly
> [fn:1] is the first thing in that line. And now invoke
> org-footnote-renumber-fn:N and see it breaking.
>
> * Footnotes
>
> [fn:1] Test
>
> Note, that in larger org files, it's likely that you don't even notice
> that the footnotes break.
It looks like the original function isn't right in more than one way (it
doesn't even make sure the matched string is really a footnote). But
that's another topic.
About your patch, I have but one question: I don't get a situation in
which the assert would be triggered, may you give me such an example?
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2011-09-29 11:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-29 9:19 [PATCH] Fix renumbering for footnotes at BOL Tassilo Horn
2011-09-29 11:41 ` Nicolas Goaziou [this message]
2011-09-29 11:51 ` Tassilo Horn
2011-09-29 13:03 ` Nicolas Goaziou
2011-09-29 13:46 ` Tassilo Horn
2011-09-29 14:01 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877h4rh8z2.fsf@gmail.com \
--to=n.goaziou@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=tassilo@member.fsf.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).