From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: [PATCH] Fix renumbering for footnotes at BOL. Date: Thu, 29 Sep 2011 13:41:05 +0200 Message-ID: <877h4rh8z2.fsf@gmail.com> References: <87ehyzk8n5.fsf@thinkpad.tsdh.de> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([140.186.70.92]:54005) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R9F0L-0004Xr-65 for emacs-orgmode@gnu.org; Thu, 29 Sep 2011 07:42:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R9F0H-0000IL-3O for emacs-orgmode@gnu.org; Thu, 29 Sep 2011 07:42:17 -0400 Received: from mail-wy0-f169.google.com ([74.125.82.169]:60499) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R9F0G-0000IA-Rr for emacs-orgmode@gnu.org; Thu, 29 Sep 2011 07:42:13 -0400 Received: by wyf22 with SMTP id 22so226483wyf.0 for ; Thu, 29 Sep 2011 04:42:11 -0700 (PDT) In-Reply-To: <87ehyzk8n5.fsf@thinkpad.tsdh.de> (Tassilo Horn's message of "Thu, 29 Sep 2011 11:19:58 +0200") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Tassilo Horn Cc: emacs-orgmode@gnu.org Hello, Tassilo Horn writes: > org-footnote-renumber-fn:N invalidates footnotes that appear as the > first thing on a line. Here's a test file including the recipe. > > * Bla > > This is a line in which the following footnote that is inserted exactly > [fn:1] is the first thing in that line. And now invoke > org-footnote-renumber-fn:N and see it breaking. > > * Footnotes > > [fn:1] Test > > Note, that in larger org files, it's likely that you don't even notice > that the footnotes break. It looks like the original function isn't right in more than one way (it doesn't even make sure the matched string is really a footnote). But that's another topic. About your patch, I have but one question: I don't get a situation in which the assert would be triggered, may you give me such an example? Regards, -- Nicolas Goaziou