From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Ryan <rct@thompsonclan.org>
Cc: emacs-orgmode@gnu.org
Subject: Re: Bug: org-in-src-block-p always returns nil [8.2.7b (8.2.7b-1-ga5beff-elpaplus @ /Users/ryan/.emacs.d/.cask/24.3.1/elpa/org-plus-contrib-20140714/)]
Date: Fri, 08 Aug 2014 10:21:39 +0200 [thread overview]
Message-ID: <877g2jo0h8.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <53E40782.2070701@thompsonclan.org> (Ryan's message of "Thu, 07 Aug 2014 16:10:58 -0700")
Hello,
Ryan <rct@thompsonclan.org> writes:
> Actually, my implementation has a bug. org-element-at-point also
> returns the element if point is actually on one of the blank lines
> between that element and the next. So I've rewritten it to handle that
> case by computing the content end position and comparing point to
> that.
Thank you. Here are a few notes about this implementation.
> (defun org-in-src-block-p (&optional inside)
> "Whether point is in a code source block.
> When INSIDE is non-nil, don't consider we are within a src block
> when point is at #+BEGIN_SRC or #+END_SRC."
> (save-match-data
> (let* ((elem (org-element-at-point))
> (elem-type (car elem))
(elem-type (org-element-type elem))
> (props (cadr elem))
> (end (plist-get props :end))
You don't need PROPS.
(end (org-element-property :end elem))
> (pb (plist-get props :post-blank))
> (content-end
> (save-excursion
> (goto-char end)
> (forward-line (- pb))
> (point)))
Using PB is incorrect.
(contend-end
(save-excursion
(goto-char end)
(skip-chars-backward " \r\t\n")
(line-beginning-position)))
> (case-fold-search t))
> (and
> ;; Elem is a src block
> (eq elem-type 'src-block)
> ;; Make sure point is not on one of the blank lines after the
> ;; element.
> (< (point) content-end)
> ;; If INSIDE is non-nil, then must not be at block delimiter
> (not
> (and
> inside
> (save-excursion
> (beginning-of-line)
> (looking-at ".*#\\+\\(begin\\|end\\)_src"))))))))
Test is simply
(and (eq elem-type 'src-block)
(if inside
(and (> (line-beginning-position) (org-element-property :post-affiliated elem))
(< (point) contents-end))
(<= (line-beginning-position) contents-end)))
Note that this is not yet possible to re-implement `org-in-src-block-p'
with `org-element-at-point' as the former is used for fontification. It
would be sub-optimal to use it that way, since you can call once
`org-element-at-point' and fontify the element under point accordingly
to its type.
Regards,
--
Nicolas Goaziou
prev parent reply other threads:[~2014-08-08 8:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-07 22:36 Bug: org-in-src-block-p always returns nil [8.2.7b (8.2.7b-1-ga5beff-elpaplus @ /Users/ryan/.emacs.d/.cask/24.3.1/elpa/org-plus-contrib-20140714/)] Ryan
2014-08-07 22:45 ` Thorsten Jolitz
2014-08-07 23:10 ` Ryan
2014-08-08 8:21 ` Nicolas Goaziou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877g2jo0h8.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=emacs-orgmode@gnu.org \
--cc=rct@thompsonclan.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).