From: Ryan <rct@thompsonclan.org>
To: emacs-orgmode@gnu.org
Subject: Re: Bug: org-in-src-block-p always returns nil [8.2.7b (8.2.7b-1-ga5beff-elpaplus @ /Users/ryan/.emacs.d/.cask/24.3.1/elpa/org-plus-contrib-20140714/)]
Date: Thu, 07 Aug 2014 16:10:58 -0700 [thread overview]
Message-ID: <53E40782.2070701@thompsonclan.org> (raw)
In-Reply-To: <53E3FF50.2050409@thompsonclan.org>
Actually, my implementation has a bug. org-element-at-point also
returns the element if point is actually on one of the blank lines
between that element and the next. So I've rewritten it to handle that
case by computing the content end position and comparing point to that.
(defun org-in-src-block-p (&optional inside)
"Whether point is in a code source block.
When INSIDE is non-nil, don't consider we are within a src block
when point is at #+BEGIN_SRC or #+END_SRC."
(save-match-data
(let* ((elem (org-element-at-point))
(elem-type (car elem))
(props (cadr elem))
(end (plist-get props :end))
(pb (plist-get props :post-blank))
(content-end
(save-excursion
(goto-char end)
(forward-line (- pb))
(point)))
(case-fold-search t))
(and
;; Elem is a src block
(eq elem-type 'src-block)
;; Make sure point is not on one of the blank lines after the
;; element.
(< (point) content-end)
;; If INSIDE is non-nil, then must not be at block delimiter
(not
(and
inside
(save-excursion
(beginning-of-line)
(looking-at ".*#\\+\\(begin\\|end\\)_src"))))))))
On Thu Aug 7 15:36:00 2014, Ryan wrote:
>
> Remember to cover the basics, that is, what you expected to happen and
> what in fact did happen. You don't know how to make a good report? See
>
> http://orgmode.org/manual/Feedback.html#Feedback
>
> Your bug report will be posted to the Org-mode mailing list.
> ------------------------------------------------------------------------
>
> I was doing some programming and wanted to use the result of
> org-in-src-block-p. I discovered that this function always returned nil,
> because for some reason (overlays-at (point)) was always returning nil
> everywhere that I tried it, including inside src blocks. So I rewrote
> org-in-src-block-p to use org-element-at-point instead of looking at
> overlays at point. My new implementation is below:
>
> (defun org-in-src-block-p (&optional inside)
> "Whether point is in a code source block.
> When INSIDE is non-nil, don't consider we are within a src block
> when point is at #+BEGIN_SRC or #+END_SRC."
> (and
> ;; In a src block
> (eq (car (org-element-at-point))
> 'src-block)
> ;; Not at block delimiter, if requested
> (not
> (and
> inside
> (let ((case-fold-search t))
> (save-match-data
> (save-excursion
> (beginning-of-line)
> (looking-at ".*#\\+\\(begin\\|end\\)_src"))))))))
>
>
> Emacs : GNU Emacs 24.3.1 (x86_64-apple-darwin13.2.0, NS
> apple-appkit-1265.20)
> of 2014-06-01 on tennine-slave.macports.org
> Package: Org-mode version 8.2.7b (8.2.7b-1-ga5beff-elpaplus @
> /Users/ryan/.emacs.d/.cask/24.3.1/elpa/org-plus-contrib-20140714/)
>
> current state:
> ==============
> (setq
> org-tab-first-hook '(org-hide-block-toggle-maybe
> org-src-native-tab-command-maybe
> org-babel-hide-result-toggle-maybe org-babel-header-arg-expand)
> org-speed-command-hook '(org-speed-command-default-hook
> org-babel-speed-command-hook)
> org-occur-hook '(org-first-headline-recenter)
> org-metaup-hook '(org-babel-load-in-session-maybe)
> org-confirm-shell-link-function 'yes-or-no-p
> org-support-shift-select t
> org-after-todo-state-change-hook '(org-clock-out-if-current)
> org-from-is-user-regexp "\\<Ryan C\\. Thompson\\>"
> org-src-mode-hook '(org-src-babel-configure-edit-buffer
> org-src-mode-configure-edit-buffer)
> org-agenda-before-write-hook '(org-agenda-add-entry-text)
> org-babel-pre-tangle-hook '(save-buffer)
> org-mode-hook '(#[nil "\300\301\302\303\304$\207"
> [org-add-hook change-major-mode-hook org-show-block-all append
> local]
> 5]
> #[nil "\300\301\302\303\304$\207"
> [org-add-hook change-major-mode-hook org-babel-show-result-all
> append local]
> 5]
> org-babel-result-hide-spec org-babel-hide-all-hashes)
> org-ctrl-c-ctrl-c-hook '(org-babel-hash-at-point
> org-babel-execute-safely-maybe)
> org-cycle-hook '(org-cycle-hide-archived-subtrees org-cycle-hide-drawers
> org-cycle-hide-inline-tasks org-cycle-show-empty-lines
> org-optimize-window-after-visibility-change)
> org-confirm-elisp-link-function 'yes-or-no-p
> org-metadown-hook '(org-babel-pop-to-session-maybe)
> org-clock-out-hook '(org-clock-remove-empty-clock-drawer)
> )
>
next prev parent reply other threads:[~2014-08-07 23:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-07 22:36 Bug: org-in-src-block-p always returns nil [8.2.7b (8.2.7b-1-ga5beff-elpaplus @ /Users/ryan/.emacs.d/.cask/24.3.1/elpa/org-plus-contrib-20140714/)] Ryan
2014-08-07 22:45 ` Thorsten Jolitz
2014-08-07 23:10 ` Ryan [this message]
2014-08-08 8:21 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53E40782.2070701@thompsonclan.org \
--to=rct@thompsonclan.org \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).