From: Aaron Ecay <aaronecay@gmail.com>
To: Eric Abrahamsen <eric@ericabrahamsen.net>, emacs-orgmode@gnu.org
Subject: Re: [PATCH RFC] subtree archive hook?
Date: Sun, 12 Oct 2014 19:13:24 +0100 [thread overview]
Message-ID: <877g05i2bf.fsf@gmail.com> (raw)
In-Reply-To: <87r3yd2rrp.fsf@ericabrahamsen.net>
Hi Eric,
2014ko urriak 12an, Eric Abrahamsen-ek idatzi zuen:
>>
>> Can the above inlinetask thing also be moved into the hook? That
>> seems cleaner, and gives another demonstration of the usefulness of
>> the feature.
>
> Here's a patch that does it, though I'm a little more cautious about
> this since I only did a minimal test.
>
> Two things that worry me: 1) why is it called "remove-END-maybe" when it
> appears to remove the whole inlinetask, and 2) it its original habitat
> in org-attach, it came after the call to org-cut-subtree, meaning that
> it couldn't have operated on the subtree to be archived at all! Or am I
> misunderstanding something?
No, you’re not misunderstanding – I was. Indeed, the inline task stuff
has to come after the call to org-cut-subtree, so it’s not a candidate
for inclusion in the new hook.
(What happens is that org-cut-subtree removes the inline task headline and
any contents, leaving a bare *** END line. The latter is subsequently
cleaned up by the org-inlinetask-remove-END-maybe call.)
Sorry for the noise,
--
Aaron Ecay
next prev parent reply other threads:[~2014-10-12 18:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-12 14:27 [PATCH RFC] subtree archive hook? Eric Abrahamsen
2014-10-12 15:22 ` Aaron Ecay
2014-10-12 16:10 ` Eric Abrahamsen
2014-10-12 18:13 ` Aaron Ecay [this message]
2014-10-12 18:45 ` Eric Abrahamsen
2014-10-13 16:13 ` Nicolas Goaziou
2014-10-14 1:55 ` Eric Abrahamsen
2014-10-16 17:03 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877g05i2bf.fsf@gmail.com \
--to=aaronecay@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=eric@ericabrahamsen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).