From mboxrd@z Thu Jan 1 00:00:00 1970 From: Aaron Ecay Subject: Re: [PATCH RFC] subtree archive hook? Date: Sun, 12 Oct 2014 19:13:24 +0100 Message-ID: <877g05i2bf.fsf@gmail.com> References: <87vbnp2wix.fsf@ericabrahamsen.net> <87oathia7m.fsf@gmail.com> <87r3yd2rrp.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:43917) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XdNeE-00040w-FD for emacs-orgmode@gnu.org; Sun, 12 Oct 2014 14:13:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XdNe5-0004K8-Dn for emacs-orgmode@gnu.org; Sun, 12 Oct 2014 14:13:38 -0400 Received: from mail-wg0-x22a.google.com ([2a00:1450:400c:c00::22a]:62896) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XdNe5-0004K4-6F for emacs-orgmode@gnu.org; Sun, 12 Oct 2014 14:13:29 -0400 Received: by mail-wg0-f42.google.com with SMTP id z12so7136197wgg.1 for ; Sun, 12 Oct 2014 11:13:28 -0700 (PDT) In-Reply-To: <87r3yd2rrp.fsf@ericabrahamsen.net> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Eric Abrahamsen , emacs-orgmode@gnu.org Hi Eric, 2014ko urriak 12an, Eric Abrahamsen-ek idatzi zuen: >>=20 >> Can the above inlinetask thing also be moved into the hook? That >> seems cleaner, and gives another demonstration of the usefulness of >> the feature. >=20 > Here's a patch that does it, though I'm a little more cautious about > this since I only did a minimal test. >=20 > Two things that worry me: 1) why is it called "remove-END-maybe" when it > appears to remove the whole inlinetask, and 2) it its original habitat > in org-attach, it came after the call to org-cut-subtree, meaning that > it couldn't have operated on the subtree to be archived at all! Or am I > misunderstanding something?=20 No, you=E2=80=99re not misunderstanding =E2=80=93 I was. Indeed, the inlin= e task stuff has to come after the call to org-cut-subtree, so it=E2=80=99s not a candid= ate for inclusion in the new hook. (What happens is that org-cut-subtree removes the inline task headline and any contents, leaving a bare *** END line. The latter is subsequently cleaned up by the org-inlinetask-remove-END-maybe call.) Sorry for the noise, --=20 Aaron Ecay