From: Nick Dokos <ndokos@gmail.com>
To: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Support time units in est+
Date: Thu, 19 Jan 2017 10:44:37 -0500 [thread overview]
Message-ID: <877f5rrr4q.fsf@gmail.com> (raw)
In-Reply-To: CAKziXDWm1AZD1wfmG=Q4UDMsg2e03afC5OHtR2hCHFhWSwTChg@mail.gmail.com
Malcolm Matalka <mmatalka@gmail.com> writes:
> Den 18 jan. 2017 22:19 skrev "Nick Dokos" <ndokos@gmail.com>:
>
> Malcolm Matalka <mmatalka@gmail.com> writes:
>
> > Hey, this is my first elisp programming so I'm quite certain this is a
> > big hack. I just stole elements from elsewhere in the file. I'm hoping
> > this is good enough to get accepted then perhaps someone with more taste
> > would be able to refactor it to be a bit better.
> >
> > Let me know if I need to change anything.
> >
>
> Yes, indeed: the first thing you should do is explain what you are
> trying to do. E.g. what does "est+" mean? Once you have explained
> *what* you are trying to do, then somebody might be able to suggest
> *how* to do it better (if it is a worthwhile thing to do in the first place).
>
> I'm not sure I understand your question. est+ is an existing functionality in columnview that is
> documented. I've brought it closer to the regular effort functionality by supporting time units.
>
My apologies: I didn't know about it.
--
Nick
next prev parent reply other threads:[~2017-01-19 15:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-18 20:33 [PATCH] Support time units in est+ Malcolm Matalka
2017-01-18 21:13 ` Nick Dokos
[not found] ` <CAKziXDUDhHJWmfm2kN+tM2WmXPiqEXTfZtQYVriCBydRqiiW7g@mail.gmail.com>
[not found] ` <CAKziXDX_3=UTBLM8v=HZJSCR2p6tqiKwSgF+a-EXvRhsp+tAjw@mail.gmail.com>
2017-01-19 4:49 ` Malcolm Matalka
2017-01-19 15:44 ` Nick Dokos [this message]
2017-02-03 12:56 ` Malcolm Matalka
2017-02-04 14:30 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877f5rrr4q.fsf@gmail.com \
--to=ndokos@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).