From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nick Dokos <ndokos@gmail.com>
Subject: Re: [PATCH] Support time units in est+
Date: Thu, 19 Jan 2017 10:44:37 -0500
Message-ID: <877f5rrr4q.fsf@gmail.com>
References: <861sw0az19.fsf@gmail.com> <87eg00ystv.fsf@gmail.com>
	<CAKziXDUDhHJWmfm2kN+tM2WmXPiqEXTfZtQYVriCBydRqiiW7g@mail.gmail.com>
	<CAKziXDX_3=UTBLM8v=HZJSCR2p6tqiKwSgF+a-EXvRhsp+tAjw@mail.gmail.com>
	<CAKziXDWm1AZD1wfmG=Q4UDMsg2e03afC5OHtR2hCHFhWSwTChg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41552)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <geo-emacs-orgmode@m.gmane.org>) id 1cUEtY-0006Mg-0x
	for emacs-orgmode@gnu.org; Thu, 19 Jan 2017 10:45:04 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <geo-emacs-orgmode@m.gmane.org>) id 1cUEtT-0004Pc-Mf
	for emacs-orgmode@gnu.org; Thu, 19 Jan 2017 10:45:00 -0500
Received: from [195.159.176.226] (port=52432 helo=blaine.gmane.org)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <geo-emacs-orgmode@m.gmane.org>)
	id 1cUEtT-0004Of-G0
	for emacs-orgmode@gnu.org; Thu, 19 Jan 2017 10:44:55 -0500
Received: from list by blaine.gmane.org with local (Exim 4.84_2)
	(envelope-from <geo-emacs-orgmode@m.gmane.org>) id 1cUEtI-00032k-LS
	for emacs-orgmode@gnu.org; Thu, 19 Jan 2017 16:44:44 +0100
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: emacs-orgmode@gnu.org

Malcolm Matalka <mmatalka@gmail.com> writes:

> Den 18 jan. 2017 22:19 skrev "Nick Dokos" <ndokos@gmail.com>:
>
>     Malcolm Matalka <mmatalka@gmail.com> writes:
>    
>     > Hey, this is my first elisp programming so I'm quite certain this is a
>     > big hack.  I just stole elements from elsewhere in the file.  I'm hoping
>     > this is good enough to get accepted then perhaps someone with more taste
>     > would be able to refactor it to be a bit better.
>     >
>     > Let me know if I need to change anything.
>     >
>    
>     Yes, indeed: the first thing you should do is explain what you are
>     trying to do.  E.g. what does "est+" mean? Once you have explained
>     *what* you are trying to do, then somebody might be able to suggest
>     *how* to do it better (if it is a worthwhile thing to do in the first place).
>
> I'm not sure I understand your question.  est+ is an existing functionality in columnview that is
> documented. I've brought it closer to the regular effort functionality by supporting time units.
>

My apologies: I didn't know about it.

-- 
Nick