From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Aliaksey Artamonau <aliaksiej.artamonau@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Fix broken one-time continuous clock-in
Date: Wed, 10 Jan 2018 12:55:48 +0100 [thread overview]
Message-ID: <877esqj5bv.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87incca03j.fsf@gmail.com> (Aliaksey Artamonau's message of "Mon, 08 Jan 2018 17:36:48 +0300")
Hello,
Aliaksey Artamonau <aliaksiej.artamonau@gmail.com> writes:
> I noticed that when I try using C-u C-u C-u `org-clock-in', I get two
> clocks started: one using last clock out time, and one using current
> time. Clocking out then closes the last one and leaves the former one
> dangling. This doesn't happen though when I have
> `org-clock-continuously' simply set to `t' and use `org-clock-in'
> without any prefix. So I started looking what the cause was. When
> triple-prefix is used, `org-clock-in' binds `org-clock-continuously'
> to `t' temporarily and calls itself recursively. But then it continues
> the execution normally once the recursive call returns. And that's
> what seemingly breaks things. The attached patch addresses the issue
> by aborting after the recursive call is over. That seemed like the
> easiest way to address the issue, but if it's not in the "spirit" o
> f org-mode, I'll be happy to work on improving the patch.
Applied. Thank you!
Regards,
--
Nicolas Goaziou
prev parent reply other threads:[~2018-01-10 11:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-08 14:36 [PATCH] Fix broken one-time continuous clock-in Aliaksey Artamonau
2018-01-10 11:55 ` Nicolas Goaziou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877esqj5bv.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=aliaksiej.artamonau@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).