From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: [PATCH] Fix broken one-time continuous clock-in Date: Wed, 10 Jan 2018 12:55:48 +0100 Message-ID: <877esqj5bv.fsf@nicolasgoaziou.fr> References: <87incca03j.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:43879) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eZEz4-0006CJ-Ig for emacs-orgmode@gnu.org; Wed, 10 Jan 2018 06:55:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eZEz1-0004fj-F6 for emacs-orgmode@gnu.org; Wed, 10 Jan 2018 06:55:54 -0500 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:55248) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eZEz1-0004eE-9l for emacs-orgmode@gnu.org; Wed, 10 Jan 2018 06:55:51 -0500 In-Reply-To: <87incca03j.fsf@gmail.com> (Aliaksey Artamonau's message of "Mon, 08 Jan 2018 17:36:48 +0300") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Aliaksey Artamonau Cc: emacs-orgmode@gnu.org Hello, Aliaksey Artamonau writes: > I noticed that when I try using C-u C-u C-u `org-clock-in', I get two > clocks started: one using last clock out time, and one using current > time. Clocking out then closes the last one and leaves the former one > dangling. This doesn't happen though when I have > `org-clock-continuously' simply set to `t' and use `org-clock-in' > without any prefix. So I started looking what the cause was. When > triple-prefix is used, `org-clock-in' binds `org-clock-continuously' > to `t' temporarily and calls itself recursively. But then it continues > the execution normally once the recursive call returns. And that's > what seemingly breaks things. The attached patch addresses the issue > by aborting after the recursive call is over. That seemed like the > easiest way to address the issue, but if it's not in the "spirit" o > f org-mode, I'll be happy to work on improving the patch. Applied. Thank you! Regards, -- Nicolas Goaziou