From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Bernt Hansen <bernt@norang.ca>
Cc: emacs-orgmode@gnu.org
Subject: Re: Bug: Inconsistent effort handling in clock totals in maint [9.1.13 (release_9.1.13 @ /home/bernt/git/org-mode/lisp/)]
Date: Mon, 14 May 2018 14:46:25 +0200 [thread overview]
Message-ID: <877eo6z9pa.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87d0xzqcq3.fsf@norang.ca> (Bernt Hansen's message of "Sun, 13 May 2018 20:53:40 -0400")
Hello,
Bernt Hansen <bernt@norang.ca> writes:
> I am fine with plain numbers being interpretted as hours. I don't
> think we need a second interpretation for it (as minutes).
The second interpretation already exists. "org-colview.el" is the sole
place where plain numbers are treated as hours. Everywhere else, plain
numbers are minutes, including in "org-clock.el".
> I don't think changing a bare 15 effort to mean minutes instead of the
> hours is a good idea - in case existing users already have effort data
> with plain numbers -- their estimates will change drastically.
I'm not proposing to change anything. I'm just suggesting a new way to
let users decide what should mean "15" when summing properties in
Columns View mode.
The issue here is you don't want to change Columns View mode, but
everything else. Or, more accurately, you want to add another exception
in plain numbers handling when displaying the mode line. This means
changing how `org-duration-to-minutes' interprets plain numbers, hence
the "everything else" part.
> Ideally I think I just want the mode line total to behave the same as
> the existing column view behaviour as far as plain numbers are concerned
> if this is easy and not causing more problems than it fixes.
We shot ourselves in the foot when we decided that one part of Org
should consider plain numbers as minutes and the other part as hours.
This is clearly sub-optimal.
I see no easy way to fix it painlessly. If we change anything, the
easier route to go is having Column View mode consider plain numbers as
minutes, because it only affects ... Column View mode itself.
We can also change nothing. I have the feeling this issue will bubble up
from time to time, though.
WDYT?
> Otherwise I can live with it -- it's been this way for years I think --
> and I will just change my effort values to always include both HH:MM and
> avoid plain numbers.
That's the most reasonable solution, IMO. Note that you can also use
"3h" instead of the ambiguous "3".
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2018-05-14 12:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-12 4:33 Bug: Inconsistent effort handling in clock totals in maint [9.1.13 (release_9.1.13 @ /home/bernt/git/org-mode/lisp/)] Bernt Hansen
2018-05-13 21:36 ` Nicolas Goaziou
2018-05-14 0:53 ` Bernt Hansen
2018-05-14 12:46 ` Nicolas Goaziou [this message]
2018-05-14 15:52 ` Bernt Hansen
2018-06-19 14:35 ` Nicolas Goaziou
2018-06-19 15:31 ` Bernt Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877eo6z9pa.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=bernt@norang.ca \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).