From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: Bug: Inconsistent effort handling in clock totals in maint [9.1.13 (release_9.1.13 @ /home/bernt/git/org-mode/lisp/)] Date: Mon, 14 May 2018 14:46:25 +0200 Message-ID: <877eo6z9pa.fsf@nicolasgoaziou.fr> References: <87lgcpqyq7.fsf@norang.ca> <87sh6vteys.fsf@nicolasgoaziou.fr> <87d0xzqcq3.fsf@norang.ca> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:47862) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fICs6-00018H-TB for emacs-orgmode@gnu.org; Mon, 14 May 2018 08:46:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fICs2-0006EW-0v for emacs-orgmode@gnu.org; Mon, 14 May 2018 08:46:34 -0400 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:48133) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fICs1-0006Dp-PS for emacs-orgmode@gnu.org; Mon, 14 May 2018 08:46:29 -0400 In-Reply-To: <87d0xzqcq3.fsf@norang.ca> (Bernt Hansen's message of "Sun, 13 May 2018 20:53:40 -0400") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Bernt Hansen Cc: emacs-orgmode@gnu.org Hello, Bernt Hansen writes: > I am fine with plain numbers being interpretted as hours. I don't > think we need a second interpretation for it (as minutes). The second interpretation already exists. "org-colview.el" is the sole place where plain numbers are treated as hours. Everywhere else, plain numbers are minutes, including in "org-clock.el". > I don't think changing a bare 15 effort to mean minutes instead of the > hours is a good idea - in case existing users already have effort data > with plain numbers -- their estimates will change drastically. I'm not proposing to change anything. I'm just suggesting a new way to let users decide what should mean "15" when summing properties in Columns View mode. The issue here is you don't want to change Columns View mode, but everything else. Or, more accurately, you want to add another exception in plain numbers handling when displaying the mode line. This means changing how `org-duration-to-minutes' interprets plain numbers, hence the "everything else" part. > Ideally I think I just want the mode line total to behave the same as > the existing column view behaviour as far as plain numbers are concerned > if this is easy and not causing more problems than it fixes. We shot ourselves in the foot when we decided that one part of Org should consider plain numbers as minutes and the other part as hours. This is clearly sub-optimal. I see no easy way to fix it painlessly. If we change anything, the easier route to go is having Column View mode consider plain numbers as minutes, because it only affects ... Column View mode itself. We can also change nothing. I have the feeling this issue will bubble up from time to time, though. WDYT? > Otherwise I can live with it -- it's been this way for years I think -- > and I will just change my effort values to always include both HH:MM and > avoid plain numbers. That's the most reasonable solution, IMO. Note that you can also use "3h" instead of the ambiguous "3". Regards, -- Nicolas Goaziou