* problem with diary sexps
@ 2022-04-01 15:44 Eric S Fraga
2022-04-05 10:28 ` Christian Stuermer
0 siblings, 1 reply; 8+ messages in thread
From: Eric S Fraga @ 2022-04-01 15:44 UTC (permalink / raw)
To: org mode mailing list
Hello all,
I updated org today and now get
Bad sexp at line 461 in /home/ucecesf/s/notes/diary.org:
(let ((entry ) (date '(4 19 2022))) (diary-float t 2 3))
for a line that looks like
<%%(diary-float t 2 3)>
This has been in my diary for a very long time with no error. I wonder
if this has anything to do with the changes to the use of advice?
Nothing else in the recent changes in the git log seem to be relevant.
Just a quick heads up as I don't have time to debug at the moment. It's
not mission critical...
Have a good weekend all.
--
: Eric S Fraga, with org release_9.5.2-423-g6d73cd in Emacs 29.0.50
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: problem with diary sexps
2022-04-01 15:44 problem with diary sexps Eric S Fraga
@ 2022-04-05 10:28 ` Christian Stuermer
2022-04-05 10:51 ` Eric S Fraga
2022-04-05 11:22 ` Ihor Radchenko
0 siblings, 2 replies; 8+ messages in thread
From: Christian Stuermer @ 2022-04-05 10:28 UTC (permalink / raw)
To: emacs-orgmode
Hello!
Eric S Fraga writes:
> I updated org today and now get
>
> Bad sexp at line 461 in /home/ucecesf/s/notes/diary.org:
> (let ((entry ) (date '(4 19 2022))) (diary-float t 2 3))
>
> for a line that looks like
>
> <%%(diary-float t 2 3)>
>
> This has been in my diary for a very long time with no error. I wonder
> if this has anything to do with the changes to the use of advice?
> Nothing else in the recent changes in the git log seem to be relevant.
I've had the same problem after updating org from git with entries like
%%(org-anniversary 2000 4 4) X is %d years old
The commit introducing it is
https://github.com/bzg/org-mode/commit/6d73cd34a07796c33f9435bfc8c9a19e67656c7a
And the problem is gone, after reverting
(result (if calendar-debug-sexp (eval sexp t)
(condition-case nil
(eval sexp t)
back to
(result (if calendar-debug-sexp (eval sexp)
(condition-case nil
(eval sexp)
in org-diary-sexp-entry in org.el.
I wrote about in on Reddit:
https://www.reddit.com/r/orgmode/comments/tvwxv0/the_commit_on_apr_1_2022_broke_organniversary_for/
Kind regards,
Christian
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: problem with diary sexps
2022-04-05 10:28 ` Christian Stuermer
@ 2022-04-05 10:51 ` Eric S Fraga
2022-04-05 11:22 ` Ihor Radchenko
1 sibling, 0 replies; 8+ messages in thread
From: Eric S Fraga @ 2022-04-05 10:51 UTC (permalink / raw)
To: Christian Stuermer; +Cc: emacs-orgmode
On Tuesday, 5 Apr 2022 at 12:28, Christian Stuermer wrote:
> I've had the same problem after updating org from git with entries like
> The commit introducing it is
> https://github.com/bzg/org-mode/commit/6d73cd34a07796c33f9435bfc8c9a19e67656c7a
>
> And the problem is gone, after reverting
>
> (result (if calendar-debug-sexp (eval sexp t)
> (condition-case nil
> (eval sexp t)
>
> back to
>
> (result (if calendar-debug-sexp (eval sexp)
> (condition-case nil
> (eval sexp)
>
> in org-diary-sexp-entry in org.el.
Confirmed. Reverting this particular change makes diary sexps work
again properly (i.e. without complaint).
Thank you,
eric
--
: Eric S Fraga, with org release_9.5.2-423-g6d73cd in Emacs 29.0.50
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: problem with diary sexps
2022-04-05 10:28 ` Christian Stuermer
2022-04-05 10:51 ` Eric S Fraga
@ 2022-04-05 11:22 ` Ihor Radchenko
2022-04-05 11:39 ` Eric S Fraga
2022-04-05 16:06 ` Max Nikulin
1 sibling, 2 replies; 8+ messages in thread
From: Ihor Radchenko @ 2022-04-05 11:22 UTC (permalink / raw)
To: Christian Stuermer; +Cc: emacs-orgmode
Christian Stuermer <orgmode-ml@recentlyrezzed.de> writes:
> And the problem is gone, after reverting
>
> (result (if calendar-debug-sexp (eval sexp t)
> (condition-case nil
> (eval sexp t)
>
> back to
>
> (result (if calendar-debug-sexp (eval sexp)
> (condition-case nil
> (eval sexp)
>
> in org-diary-sexp-entry in org.el.
More accurate error can be found after setting calendar-debug-sexp to t.
I got the following backtrace clearly indicating lexical scope issue:
Debugger entered--Lisp error: (void-variable entry)
(diary-float t 2 1)
(let ((entry "") (date '(4 5 2022))) (diary-float t 2 1))
(eval (let ((entry "") (date '(4 5 2022))) (diary-float t 2 1)) t)
Best,
Ihor
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: problem with diary sexps
2022-04-05 11:22 ` Ihor Radchenko
@ 2022-04-05 11:39 ` Eric S Fraga
2022-04-08 2:59 ` Ihor Radchenko
2022-04-05 16:06 ` Max Nikulin
1 sibling, 1 reply; 8+ messages in thread
From: Eric S Fraga @ 2022-04-05 11:39 UTC (permalink / raw)
To: Ihor Radchenko; +Cc: Christian Stuermer, emacs-orgmode
On Tuesday, 5 Apr 2022 at 19:22, Ihor Radchenko wrote:
> More accurate error can be found after setting calendar-debug-sexp to t.
> I got the following backtrace clearly indicating lexical scope issue:
Which makes sense. The diary code does use entry and date as global
variables so really needs updating...
--
: Eric S Fraga, with org release_9.5.2-423-g6d73cd in Emacs 29.0.50
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: problem with diary sexps
2022-04-05 11:22 ` Ihor Radchenko
2022-04-05 11:39 ` Eric S Fraga
@ 2022-04-05 16:06 ` Max Nikulin
1 sibling, 0 replies; 8+ messages in thread
From: Max Nikulin @ 2022-04-05 16:06 UTC (permalink / raw)
To: emacs-orgmode
On 05/04/2022 18:22, Ihor Radchenko wrote:
> Christian Stuermer writes:
>
>> And the problem is gone, after reverting
>>
>> (result (if calendar-debug-sexp (eval sexp t)
>> (condition-case nil
>> (eval sexp t)
>>
>> back to
>>
>> (result (if calendar-debug-sexp (eval sexp)
>> (condition-case nil
>> (eval sexp)
>>
>> in org-diary-sexp-entry in org.el.
>
> More accurate error can be found after setting calendar-debug-sexp to t.
> I got the following backtrace clearly indicating lexical scope issue:
>
> Debugger entered--Lisp error: (void-variable entry)
> (diary-float t 2 1)
> (let ((entry "") (date '(4 5 2022))) (diary-float t 2 1))
> (eval (let ((entry "") (date '(4 5 2022))) (diary-float t 2 1)) t)
It looks like the source of the problem with unit tests that I faced
yesterday trying to look closer at the bug with daylight saving time in
agenda.
Bad sexp at line 25 in /home/ubuntu/src/org-mode/testing/examples
/agenda-file.org: (let ((entry ) (date '(3 25 2022))) (diary-date 3 25
2022))
((should
(= 3
(count-lines ... ...)))
:form
FAILED 255/900 test-org-agenda/property-timestamp (2.018120 sec)
Emacs-27.3
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-04-08 10:52 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-01 15:44 problem with diary sexps Eric S Fraga
2022-04-05 10:28 ` Christian Stuermer
2022-04-05 10:51 ` Eric S Fraga
2022-04-05 11:22 ` Ihor Radchenko
2022-04-05 11:39 ` Eric S Fraga
2022-04-08 2:59 ` Ihor Radchenko
2022-04-08 10:46 ` Eric S Fraga
2022-04-05 16:06 ` Max Nikulin
Code repositories for project(s) associated with this inbox:
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).