emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* extended background on org-block-end-line
@ 2022-11-08 17:52 Al Haji-Ali
  2022-11-09  2:26 ` Ihor Radchenko
  0 siblings, 1 reply; 4+ messages in thread
From: Al Haji-Ali @ 2022-11-08 17:52 UTC (permalink / raw)
  To: emacs-orgmode


I'll admit this "bug" is not critical, but it is visually annoying (at least to me).
When hiding an org entry, source blocks with extended backgrounds remain visible.

To re-produce:

0. Run `emacs -Q`

1. Create a buffer with this content and ensure `org-mode` is on
------------------------------------------------------------
* One
#+begin_src emacs-lisp
#+end_src
* Two
#+begin_src emacs-lisp
#+end_src
------------------------------------------------------------

2. Change the face `org-block-end-line` to have an extended background on the end-line of the
org-block

(set-face-attribute
   'org-block-end-line nil
   :extend t
   :background "#4e5079")

4. Go to "One" and press tab

5. Notice how the background colour now appears next to "One".

Is there a way to fix this? Note that if the org-block is not the last line in the entry (for example if there's an empty line before "* Two") then the visual artefact is not present.  

-- Al


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: extended background on org-block-end-line
  2022-11-08 17:52 extended background on org-block-end-line Al Haji-Ali
@ 2022-11-09  2:26 ` Ihor Radchenko
  2022-11-09 14:14   ` Abdul-Lateef Haji-Ali
  0 siblings, 1 reply; 4+ messages in thread
From: Ihor Radchenko @ 2022-11-09  2:26 UTC (permalink / raw)
  To: Al Haji-Ali; +Cc: emacs-orgmode

Al Haji-Ali <abdo.haji.ali@gmail.com> writes:

> I'll admit this "bug" is not critical, but it is visually annoying (at least to me).
> When hiding an org entry, source blocks with extended backgrounds remain visible.
>
> To re-produce:
> ...
> 5. Notice how the background colour now appears next to "One".
>
> Is there a way to fix this? Note that if the org-block is not the last line in the entry (for example if there's an empty line before "* Two") then the visual artefact is not present.  

Thanks for reporting!
Confirmed.

This is because Org keeps the last newline visible and Emacs apply
:extent t to that visible newline.

I do not think that we can do much about this on Org side.
I have redirected this bug report to Emacs devs.
See https://debbugs.gnu.org/cgi/bugreport.cgi?bug=59141

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: extended background on org-block-end-line
  2022-11-09  2:26 ` Ihor Radchenko
@ 2022-11-09 14:14   ` Abdul-Lateef Haji-Ali
  2022-11-10  1:38     ` Ihor Radchenko
  0 siblings, 1 reply; 4+ messages in thread
From: Abdul-Lateef Haji-Ali @ 2022-11-09 14:14 UTC (permalink / raw)
  To: Ihor Radchenko; +Cc: emacs-orgmode

Hello Ihor,

On 09/11/2022, Ihor Radchenko wrote:
> This is because Org keeps the last newline visible and Emacs apply
> :extent t to that visible newline.

I saw the bug report on Emacs, but I am not sure how to reply to a thread there without being subscribed to the mailing list, so I will reply here.

I think a possible solution that can be implemented in org-mode side would be for the outline to include the new line character after `#+end_src` to hide the whole line (including the extended background). The final result can then be fixed by adding a newline character to the `...` glyph.

Do you think that would work? 

-- Al


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: extended background on org-block-end-line
  2022-11-09 14:14   ` Abdul-Lateef Haji-Ali
@ 2022-11-10  1:38     ` Ihor Radchenko
  0 siblings, 0 replies; 4+ messages in thread
From: Ihor Radchenko @ 2022-11-10  1:38 UTC (permalink / raw)
  To: Abdul-Lateef Haji-Ali; +Cc: emacs-orgmode

Abdul-Lateef Haji-Ali <abdo.haji.ali@gmail.com> writes:

> I saw the bug report on Emacs, but I am not sure how to reply to a thread there without being subscribed to the mailing list, so I will reply here.

You can reply in https://yhetil.org/emacs-bugs/87o7tfkby9.fsf@gmail.com/T/#t

> I think a possible solution that can be implemented in org-mode side would be for the outline to include the new line character after `#+end_src` to hide the whole line (including the extended background). The final result can then be fixed by adding a newline character to the `...` glyph.

Juri proposed a similar idea in
https://yhetil.org/emacs-bugs/87o7tfkby9.fsf@gmail.com/T/#m7baceaf9a109cc7ca118b7e834cbfaa7c7e792fd
I replied there.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-11-10  1:38 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-08 17:52 extended background on org-block-end-line Al Haji-Ali
2022-11-09  2:26 ` Ihor Radchenko
2022-11-09 14:14   ` Abdul-Lateef Haji-Ali
2022-11-10  1:38     ` Ihor Radchenko

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).