emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* [PATCH] Fixes org-rmail-follow-link
@ 2012-08-08 22:00 T.F. Torrey
  2012-08-10  8:00 ` Bastien
  0 siblings, 1 reply; 2+ messages in thread
From: T.F. Torrey @ 2012-08-08 22:00 UTC (permalink / raw)
  To: emacs-orgmode

[-- Attachment #1: Type: text/plain, Size: 876 bytes --]

With creating links working in Rmail, now I see that following links
fails with the error "Message not found".

The error comes from the use of the function widen in
org-rmail-follow-link. In an RMAIL buffer, the widen function only
widens to the current message. The function to widen to the entire
buffer is rmail-widen.

The attached patch replaces widen with rmail-widen and also removes the
following two lines (added by Bastien as part of the previous patch re
Rmail), because rmail-widen already displays full headers, so testing
and toggling them on has no effect.

GNU Emacs 24.1.50.1 (i686-pc-linux-gnu, GTK+ Version 3.4.2) of
2012-07-29 on doubah, modified by Debian

Org-mode version 7.8.11 (release_7.8.11-392-g9dae6f-git @ mixed
installation! /usr/local/share/emacs/site-lisp/ and
/home/tftorrey/.emacs.d/src/org-mode/lisp/)

Best to all,
Terry
-- 
T.F. Torrey


[-- Attachment #2: Patch for org-rmail-follow-link --]
[-- Type: text/plain, Size: 465 bytes --]

diff --git a/lisp/org-rmail.el b/lisp/org-rmail.el
index 9148a8e..d28a420 100644
--- a/lisp/org-rmail.el
+++ b/lisp/org-rmail.el
@@ -101,9 +101,7 @@
 	(rmail (if (string= folder "RMAIL") rmail-file-name folder))
 	(setq message-number
 	      (save-restriction
-		(widen)
-		(when (eq rmail-header-style 'normal)
-		  (rmail-toggle-header -1))
+		(rmail-widen)
 		(goto-char (point-max))
 		(if (re-search-backward
 		     (concat "^Message-ID:\\s-+" (regexp-quote

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Fixes org-rmail-follow-link
  2012-08-08 22:00 [PATCH] Fixes org-rmail-follow-link T.F. Torrey
@ 2012-08-10  8:00 ` Bastien
  0 siblings, 0 replies; 2+ messages in thread
From: Bastien @ 2012-08-10  8:00 UTC (permalink / raw)
  To: T.F. Torrey; +Cc: emacs-orgmode

tftorrey@tftorrey.com (T.F. Torrey) writes:

> With creating links working in Rmail, now I see that following links
> fails with the error "Message not found".
>
> The error comes from the use of the function widen in
> org-rmail-follow-link. In an RMAIL buffer, the widen function only
> widens to the current message. The function to widen to the entire
> buffer is rmail-widen.
>
> The attached patch replaces widen with rmail-widen and also removes the
> following two lines (added by Bastien as part of the previous patch re
> Rmail), because rmail-widen already displays full headers, so testing
> and toggling them on has no effect.

Applied, thanks.

Please send a properly formatted ChangeLog next time:
http://orgmode.org/worg/org-contribute.html#sec-5

Best,

-- 
 Bastien

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-08-10  7:59 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-08-08 22:00 [PATCH] Fixes org-rmail-follow-link T.F. Torrey
2012-08-10  8:00 ` Bastien

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).