From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Thorsten Jolitz <tjolitz@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [RFC] Rewrite `org-entry-properties' using parser
Date: Wed, 06 Aug 2014 14:04:03 +0200 [thread overview]
Message-ID: <8761i525ak.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <874mxrw139.fsf@gmail.com> (Thorsten Jolitz's message of "Tue, 05 Aug 2014 14:52:10 +0200")
Hello,
Thorsten Jolitz <tjolitz@gmail.com> writes:
> Thanks for the review and the comments. But this looks like an entirely
> different function to me
I think you're confused between `org-element-at-point' and
`org-entry-properties'. As I pointed out, there are properties that
ought to stay specific to the former (e.g. :contents-begin) and some
specific to the latter (e.g. :clocksum).
As I said, sharing code for the common parts is "interesting". But it is
not sufficient.
Another option would be to discuss if `org-entry-properties' is needed
at all. AFAICT by grepping for "org-entry-properties" through the code
base, besides "org-pcomplete.el", no call is really needed. Most
functions really need a single property. It is inefficient to grab them
all just to extract one.
> and IMO it does not make much sense that you explain what you want
> and I type it in (because instead of explaining you could just as well
> type it yourself in the same time)
You may want to read my answer again. There is no "write this, write
that" in it. I'm pointing out what is missing or flawed and _suggesting_
alternative approaches.
> so I rather leave this to you (or whoever wants to do it).
Unfortunately, my plate is full at the moment.
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2014-08-06 12:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-31 23:21 [RFC] Rewrite `org-entry-properties' using parser Thorsten Jolitz
2014-08-01 11:44 ` Bastien
2014-08-01 12:44 ` Thorsten Jolitz
2014-08-01 13:28 ` Nicolas Goaziou
2014-08-05 12:52 ` Thorsten Jolitz
2014-08-06 9:59 ` Rasmus
2014-08-06 12:04 ` Nicolas Goaziou [this message]
2014-08-21 0:16 ` Thorsten Jolitz
2014-08-01 18:41 ` Erik Hetzner
2014-08-03 18:59 ` John Kitchin
2014-08-04 3:45 ` Erik Hetzner
2014-08-04 4:07 ` Aaron Ecay
2014-08-04 14:11 ` Erik Hetzner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8761i525ak.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=emacs-orgmode@gnu.org \
--cc=tjolitz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).