From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: [RFC] Rewrite `org-entry-properties' using parser
Date: Wed, 06 Aug 2014 14:04:03 +0200
Message-ID: <8761i525ak.fsf@nicolasgoaziou.fr>
References: <87tx5xunas.fsf@gmail.com> <87a97o9w53.fsf@nicolasgoaziou.fr>
	<874mxrw139.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43580)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1XEzwI-0004Vj-R4
	for emacs-orgmode@gnu.org; Wed, 06 Aug 2014 08:03:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1XEzw8-0001WW-M6
	for emacs-orgmode@gnu.org; Wed, 06 Aug 2014 08:03:30 -0400
Received: from relay3-d.mail.gandi.net ([2001:4b98:c:538::195]:42632)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1XEzw8-0001W3-FY
	for emacs-orgmode@gnu.org; Wed, 06 Aug 2014 08:03:20 -0400
In-Reply-To: <874mxrw139.fsf@gmail.com> (Thorsten Jolitz's message of "Tue, 05
	Aug 2014 14:52:10 +0200")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Thorsten Jolitz <tjolitz@gmail.com>
Cc: emacs-orgmode@gnu.org

Hello,

Thorsten Jolitz <tjolitz@gmail.com> writes:

> Thanks for the review and the comments. But this looks like an entirely
> different function to me

I think you're confused between `org-element-at-point' and
`org-entry-properties'. As I pointed out, there are properties that
ought to stay specific to the former (e.g. :contents-begin) and some
specific to the latter (e.g. :clocksum).

As I said, sharing code for the common parts is "interesting". But it is
not sufficient.

Another option would be to discuss if `org-entry-properties' is needed
at all. AFAICT by grepping for "org-entry-properties" through the code
base, besides "org-pcomplete.el", no call is really needed. Most
functions really need a single property. It is inefficient to grab them
all just to extract one.

> and IMO it does not make much sense that you explain what you want
> and I type it in (because instead of explaining you could just as well
> type it yourself in the same time)

You may want to read my answer again. There is no "write this, write
that" in it. I'm pointing out what is missing or flawed and _suggesting_
alternative approaches.

> so I rather leave this to you (or whoever wants to do it).

Unfortunately, my plate is full at the moment.


Regards,

-- 
Nicolas Goaziou