emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Gerald Wildgruber <Gerald.Wildgruber@unibas.ch>
To: Rasmus <rasmus@gmx.us>
Cc: emacs-orgmode@gnu.org
Subject: Re: Cookies on check-boxed plain lists don't get updated
Date: Mon, 10 Aug 2015 17:32:30 +0200	[thread overview]
Message-ID: <87614ncg6p.fsf@unibas.ch> (raw)
In-Reply-To: <87k2t3i7ie.fsf@gmx.us>


Hi Rasmus,

thanks for your hint, indeed this particular commit changed the
check-box related algorithm; "git log" gives:

commit a4cc9d82d8069741be64c55f35f9d3ad7e2663d5
Author: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Date:   Tue Jun 9 17:06:17 2015 +0200

    org-list: Fix checkbox update with inlinetasks
    
    * lisp/org-list.el (org-update-checkbox-count): Change algorithm.  Use
      Element parser.
    
    * testing/lisp/test-org-list.el (test-org-list/update-checkbox-count):
      New test.


I then looked at this particular file's git log:

git log lisp/org-list.el

and checked out Nicolas' last revision BEFORE his commit on Tue Jun 9:

git checkout a0c1e490b30cc4c0dd9e9ecdd70c32a52b08a57e lisp/org-list.el

And indeed: everything works again as expected.

Nicolas, can you see what caused this regression and can it be fixed?


Thanks

Gerald.


On Mo, Aug 10 2015, Rasmus <rasmus@gmx.us> wrote:

> Hi,
>
> I can reproduce.
>
> Gerald Wildgruber <Gerald.Wildgruber@unibas.ch> writes:
>
>> =====================================
>>
>> * TODO Heading [0/3]
>>
>> - [ ] entry 1
>> - [ ] entry 2 [0/0]
>>     - [ ] sub-entry 1
>>     - [ ] sub-entry 2
>>     - [ ] sub-entry 3
>> - [ ] entry 3
>>
>> =====================================
>
> I don't have time to attempt to fix it now, but it's introduced in
> a4cc9d82d8069741be64c55f35f9d3ad7e2663d5 if my git bisect foo is correct.
>
> My guess would be that container goes too far back:
>
>     + (container
>     +                    (org-element-lineage
>     +                     context
>     +                     '(drawer center-block dynamic-block inlinetask plain-list
>     +                              quote-block special-block verse-block))
>
> plain-list also includes entry 1, but it should only consider the sublist
> starting with entry 2.
>
> Rasmus

next prev parent reply	other threads:[~2015-08-10 15:32 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-10 12:50 Cookies on check-boxed plain lists don't get updated Gerald Wildgruber
2015-08-10 13:43 ` Rasmus
2015-08-10 15:32   ` Gerald Wildgruber [this message]
2015-08-10 21:29     ` Nicolas Goaziou
2015-08-11  7:40       ` Gerald Wildgruber
2015-08-11  8:57         ` Rasmus
2015-08-11  9:40           ` Gerald Wildgruber
2015-08-11 12:15           ` Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87614ncg6p.fsf@unibas.ch \
    --to=gerald.wildgruber@unibas.ch \
    --cc=emacs-orgmode@gnu.org \
    --cc=rasmus@gmx.us \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).