From mboxrd@z Thu Jan  1 00:00:00 1970
From: Gerald Wildgruber <Gerald.Wildgruber@unibas.ch>
Subject: Re: Cookies on check-boxed plain lists don't get updated
Date: Mon, 10 Aug 2015 17:32:30 +0200
Message-ID: <87614ncg6p.fsf@unibas.ch>
References: <877fp3b94c.fsf@unibas.ch> <87k2t3i7ie.fsf@gmx.us>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41245)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Gerald.Wildgruber@unibas.ch>) id 1ZOp40-00064y-6Q
	for emacs-orgmode@gnu.org; Mon, 10 Aug 2015 11:32:37 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Gerald.Wildgruber@unibas.ch>) id 1ZOp3w-0002WF-Qa
	for emacs-orgmode@gnu.org; Mon, 10 Aug 2015 11:32:36 -0400
Received: from mx2-priv.urz.unibas.ch ([131.152.226.165]:40261)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Gerald.Wildgruber@unibas.ch>) id 1ZOp3w-0002Vg-L3
	for emacs-orgmode@gnu.org; Mon, 10 Aug 2015 11:32:32 -0400
In-reply-to: <87k2t3i7ie.fsf@gmx.us>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Rasmus <rasmus@gmx.us>
Cc: emacs-orgmode@gnu.org


Hi Rasmus,

thanks for your hint, indeed this particular commit changed the
check-box related algorithm; "git log" gives:

commit a4cc9d82d8069741be64c55f35f9d3ad7e2663d5
Author: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Date:   Tue Jun 9 17:06:17 2015 +0200

    org-list: Fix checkbox update with inlinetasks
    
    * lisp/org-list.el (org-update-checkbox-count): Change algorithm.  Use
      Element parser.
    
    * testing/lisp/test-org-list.el (test-org-list/update-checkbox-count):
      New test.


I then looked at this particular file's git log:

git log lisp/org-list.el

and checked out Nicolas' last revision BEFORE his commit on Tue Jun 9:

git checkout a0c1e490b30cc4c0dd9e9ecdd70c32a52b08a57e lisp/org-list.el

And indeed: everything works again as expected.

Nicolas, can you see what caused this regression and can it be fixed?


Thanks

Gerald.


On Mo, Aug 10 2015, Rasmus <rasmus@gmx.us> wrote:

> Hi,
>
> I can reproduce.
>
> Gerald Wildgruber <Gerald.Wildgruber@unibas.ch> writes:
>
>> =====================================
>>
>> * TODO Heading [0/3]
>>
>> - [ ] entry 1
>> - [ ] entry 2 [0/0]
>>     - [ ] sub-entry 1
>>     - [ ] sub-entry 2
>>     - [ ] sub-entry 3
>> - [ ] entry 3
>>
>> =====================================
>
> I don't have time to attempt to fix it now, but it's introduced in
> a4cc9d82d8069741be64c55f35f9d3ad7e2663d5 if my git bisect foo is correct.
>
> My guess would be that container goes too far back:
>
>     + (container
>     +                    (org-element-lineage
>     +                     context
>     +                     '(drawer center-block dynamic-block inlinetask plain-list
>     +                              quote-block special-block verse-block))
>
> plain-list also includes entry 1, but it should only consider the sublist
> starting with entry 2.
>
> Rasmus