emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Bastien <bzg@gnu.org>
To: Ihor Radchenko <yantar92@gmail.com>
Cc: Org-mode <emacs-orgmode@gnu.org>
Subject: Re: Bug: org-contacts.el: org-contacts-link-store breaks org-id [9.4.2 (release_9.4.2-307-g8840af @ /home/yantar92/.emacs.d/straight/build/org/)]
Date: Thu, 17 Dec 2020 06:03:20 +0100	[thread overview]
Message-ID: <875z51nhwn.fsf@bzg.fr> (raw)
In-Reply-To: <87sg855ct6.fsf@localhost> (Ihor Radchenko's message of "Thu, 17 Dec 2020 11:30:45 +0800")

Ihor Radchenko <yantar92@gmail.com> writes:

> stardiviner <numbchild@gmail.com> writes:
>
>> Sure, I didn't expected that soon bug appears. I checked source code, I
>> commented out an condition accidentally.
>> Here is the patch. Tested it should work now.
>
> What about adding support for org-id? Is it necessary to use headline
> text as a search string even when org-id is being used (and
> org-id-link-to-org-use-id is set to non-nil)?

I don't know what's the best solution here, but stardiviner feel free
to commit patches yourself, as this is part of contrib/.

-- 
 Bastien


  reply	other threads:[~2020-12-17  5:04 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-16  8:48 Ihor Radchenko
2020-12-16 11:40 ` Bastien
2020-12-17  0:25   ` stardiviner
2020-12-17  3:30     ` Ihor Radchenko
2020-12-17  5:03       ` Bastien [this message]
2020-12-17  5:08         ` stardiviner
2020-12-17  5:18           ` Bastien
2020-12-17  5:25             ` stardiviner
2020-12-17  5:52               ` Bastien
2020-12-17  5:07       ` stardiviner
2020-12-17  6:40       ` stardiviner
2020-12-17  7:20         ` Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875z51nhwn.fsf@bzg.fr \
    --to=bzg@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=yantar92@gmail.com \
    --subject='Re: Bug: org-contacts.el: org-contacts-link-store breaks org-id [9.4.2 (release_9.4.2-307-g8840af @ /home/yantar92/.emacs.d/straight/build/org/)]' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).