emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: stardiviner <numbchild@gmail.com>
To: Bastien <bzg@gnu.org>
Cc: Org-mode <emacs-orgmode@gnu.org>, Ihor Radchenko <yantar92@gmail.com>
Subject: Re: Bug: org-contacts.el: org-contacts-link-store breaks org-id [9.4.2 (release_9.4.2-307-g8840af @ /home/yantar92/.emacs.d/straight/build/org/)]
Date: Thu, 17 Dec 2020 13:08:37 +0800	[thread overview]
Message-ID: <CAL1eYuK3R0vOq2CU8wg7A8SA5f-Amv9zNhYiEYvG77MJUwUVUg@mail.gmail.com> (raw)
In-Reply-To: <875z51nhwn.fsf@bzg.fr>

[-- Attachment #1: Type: text/plain, Size: 1015 bytes --]

Does that means I can push to org-contacts.el directly by myself?
That's simpler. Thanks.

[stardiviner]           <Hack this world!>      GPG key ID: 47C32433
IRC(freeenode): stardiviner                     Twitter:  @numbchild
Key fingerprint = 9BAA 92BC CDDD B9EF 3B36  CB99 B8C4 B8E5 47C3 2433
Blog: http://stardiviner.github.io/


On Thu, Dec 17, 2020 at 1:03 PM Bastien <bzg@gnu.org> wrote:

> Ihor Radchenko <yantar92@gmail.com> writes:
>
> > stardiviner <numbchild@gmail.com> writes:
> >
> >> Sure, I didn't expected that soon bug appears. I checked source code, I
> >> commented out an condition accidentally.
> >> Here is the patch. Tested it should work now.
> >
> > What about adding support for org-id? Is it necessary to use headline
> > text as a search string even when org-id is being used (and
> > org-id-link-to-org-use-id is set to non-nil)?
>
> I don't know what's the best solution here, but stardiviner feel free
> to commit patches yourself, as this is part of contrib/.
>
> --
>  Bastien
>

[-- Attachment #2: Type: text/html, Size: 2025 bytes --]

  reply	other threads:[~2020-12-17  5:10 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-16  8:48 Ihor Radchenko
2020-12-16 11:40 ` Bastien
2020-12-17  0:25   ` stardiviner
2020-12-17  3:30     ` Ihor Radchenko
2020-12-17  5:03       ` Bastien
2020-12-17  5:08         ` stardiviner [this message]
2020-12-17  5:18           ` Bastien
2020-12-17  5:25             ` stardiviner
2020-12-17  5:52               ` Bastien
2020-12-17  5:07       ` stardiviner
2020-12-17  6:40       ` stardiviner
2020-12-17  7:20         ` Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAL1eYuK3R0vOq2CU8wg7A8SA5f-Amv9zNhYiEYvG77MJUwUVUg@mail.gmail.com \
    --to=numbchild@gmail.com \
    --cc=bzg@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=yantar92@gmail.com \
    --subject='Re: Bug: org-contacts.el: org-contacts-link-store breaks org-id [9.4.2 (release_9.4.2-307-g8840af @ /home/yantar92/.emacs.d/straight/build/org/)]' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).