emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* Patch for org-babel manual node
@ 2011-04-21 17:11 Robert P. Goldman
  2011-04-21 17:12 ` [PATCH] Fixed shell script example in "Emacs Lisp evaluation of variables." Robert P. Goldman
  2011-04-21 20:56 ` Patch for org-babel manual node Eric Schulte
  0 siblings, 2 replies; 6+ messages in thread
From: Robert P. Goldman @ 2011-04-21 17:11 UTC (permalink / raw)
  To: emacs-orgmode

There was a bug in an example of argument passing in the org-babel
part of the manual.  Fixed in the following patch.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH] Fixed shell script example in "Emacs Lisp evaluation of variables."
  2011-04-21 17:11 Patch for org-babel manual node Robert P. Goldman
@ 2011-04-21 17:12 ` Robert P. Goldman
  2011-05-02  9:09   ` [Accepted] " Carsten Dominik
  2011-04-21 20:56 ` Patch for org-babel manual node Eric Schulte
  1 sibling, 1 reply; 6+ messages in thread
From: Robert P. Goldman @ 2011-04-21 17:12 UTC (permalink / raw)
  To: emacs-orgmode; +Cc: Robert P. Goldman

The variable names in the header arguments and in the sh code didn't line
up.  Made them agree.
---
 doc/org.texi |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/doc/org.texi b/doc/org.texi
index 17922d4..e68ed18 100644
--- a/doc/org.texi
+++ b/doc/org.texi
@@ -12072,8 +12072,8 @@ org-mode file, while there is no such guarantee for evaluation of the code
 block body.
 
 @example
-#+begin_src sh :var file-name=(buffer-file-name) :exports both
-  wc -w $file
+#+begin_src sh :var filename=(buffer-file-name) :exports both
+  wc -w $filename
 #+end_src
 @end example
 
-- 
1.7.3.5

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Patch for org-babel manual node
  2011-04-21 17:11 Patch for org-babel manual node Robert P. Goldman
  2011-04-21 17:12 ` [PATCH] Fixed shell script example in "Emacs Lisp evaluation of variables." Robert P. Goldman
@ 2011-04-21 20:56 ` Eric Schulte
  2011-04-21 21:17   ` Robert Goldman
  1 sibling, 1 reply; 6+ messages in thread
From: Eric Schulte @ 2011-04-21 20:56 UTC (permalink / raw)
  To: Robert P. Goldman; +Cc: emacs-orgmode

Patch appears to be missing, could you resend?

Thanks -- Eric

"Robert P. Goldman" <rpgoldman@real-time.com> writes:

> There was a bug in an example of argument passing in the org-babel
> part of the manual.  Fixed in the following patch.
>
>

-- 
Eric Schulte
http://cs.unm.edu/~eschulte/

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Patch for org-babel manual node
  2011-04-21 20:56 ` Patch for org-babel manual node Eric Schulte
@ 2011-04-21 21:17   ` Robert Goldman
  2011-04-22 14:07     ` Eric Schulte
  0 siblings, 1 reply; 6+ messages in thread
From: Robert Goldman @ 2011-04-21 21:17 UTC (permalink / raw)
  To: Eric Schulte; +Cc: emacs-orgmode

[-- Attachment #1: Type: text/plain, Size: 377 bytes --]

On 4/21/11 Apr 21 -3:56 PM, Eric Schulte wrote:
> Patch appears to be missing, could you resend?

Hope this will go through better....

LMK if you don't get it.
> 
> Thanks -- Eric
> 
> "Robert P. Goldman" <rpgoldman@real-time.com> writes:
> 
>> There was a bug in an example of argument passing in the org-babel
>> part of the manual.  Fixed in the following patch.
>>
>>
> 


[-- Attachment #2: 0001-Fixed-shell-script-example-in-Emacs-Lisp-evaluation-.patch --]
[-- Type: text/plain, Size: 856 bytes --]

From 31bd57dc0a904ca0b42f46dd1c10fc772c678343 Mon Sep 17 00:00:00 2001
From: Robert P. Goldman <rpgoldman@real-time.com>
Date: Thu, 21 Apr 2011 12:09:57 -0500
Subject: [PATCH] Fixed shell script example in "Emacs Lisp evaluation of variables."

The variable names in the header arguments and in the sh code didn't line
up.  Made them agree.
---
 doc/org.texi |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/doc/org.texi b/doc/org.texi
index 17922d4..e68ed18 100644
--- a/doc/org.texi
+++ b/doc/org.texi
@@ -12072,8 +12072,8 @@ org-mode file, while there is no such guarantee for evaluation of the code
 block body.
 
 @example
-#+begin_src sh :var file-name=(buffer-file-name) :exports both
-  wc -w $file
+#+begin_src sh :var filename=(buffer-file-name) :exports both
+  wc -w $filename
 #+end_src
 @end example
 
-- 
1.7.3.5


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Patch for org-babel manual node
  2011-04-21 21:17   ` Robert Goldman
@ 2011-04-22 14:07     ` Eric Schulte
  0 siblings, 0 replies; 6+ messages in thread
From: Eric Schulte @ 2011-04-22 14:07 UTC (permalink / raw)
  To: rpgoldman; +Cc: emacs-orgmode

Hi Robert, I've just applied this patch.  Thanks! -- Eric

Robert Goldman <rpgoldman@real-time.com> writes:

> On 4/21/11 Apr 21 -3:56 PM, Eric Schulte wrote:
>> Patch appears to be missing, could you resend?
>
> Hope this will go through better....
>
> LMK if you don't get it.
>> 
>> Thanks -- Eric
>> 
>> "Robert P. Goldman" <rpgoldman@real-time.com> writes:
>> 
>>> There was a bug in an example of argument passing in the org-babel
>>> part of the manual.  Fixed in the following patch.
>>>
>>>
>> 
>
>

-- 
Eric Schulte
http://cs.unm.edu/~eschulte/

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Accepted] Fixed shell script example in "Emacs Lisp evaluation of variables."
  2011-04-21 17:12 ` [PATCH] Fixed shell script example in "Emacs Lisp evaluation of variables." Robert P. Goldman
@ 2011-05-02  9:09   ` Carsten Dominik
  0 siblings, 0 replies; 6+ messages in thread
From: Carsten Dominik @ 2011-05-02  9:09 UTC (permalink / raw)
  To: emacs-orgmode

Patch 756 (http://patchwork.newartisans.com/patch/756/) is now "Accepted".

Maintainer comment: none

This relates to the following submission:

http://mid.gmane.org/%3C1303405920-1184-2-git-send-email-rpgoldman%40real-time.com%3E

Here is the original message containing the patch:

> Content-Type: text/plain; charset="utf-8"
> MIME-Version: 1.0
> Content-Transfer-Encoding: 7bit
> Subject: [O] Fixed shell script example in "Emacs Lisp evaluation of
> 	variables."
> Date: Thu, 21 Apr 2011 22:12:00 -0000
> From: Robert P. Goldman <rpgoldman@real-time.com>
> X-Patchwork-Id: 756
> Message-Id: <1303405920-1184-2-git-send-email-rpgoldman@real-time.com>
> To: emacs-orgmode@gnu.org
> Cc: "Robert P. Goldman" <rpgoldman@real-time.com>
> 
> The variable names in the header arguments and in the sh code didn't line
> up.  Made them agree.
> 
> ---
> doc/org.texi |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/doc/org.texi b/doc/org.texi
> index 17922d4..e68ed18 100644
> --- a/doc/org.texi
> +++ b/doc/org.texi
> @@ -12072,8 +12072,8 @@ org-mode file, while there is no such guarantee for evaluation of the code
>  block body.
>  
>  @example
> -#+begin_src sh :var file-name=(buffer-file-name) :exports both
> -  wc -w $file
> +#+begin_src sh :var filename=(buffer-file-name) :exports both
> +  wc -w $filename
>  #+end_src
>  @end example
>  
> 

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2011-05-02  9:09 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-04-21 17:11 Patch for org-babel manual node Robert P. Goldman
2011-04-21 17:12 ` [PATCH] Fixed shell script example in "Emacs Lisp evaluation of variables." Robert P. Goldman
2011-05-02  9:09   ` [Accepted] " Carsten Dominik
2011-04-21 20:56 ` Patch for org-babel manual node Eric Schulte
2011-04-21 21:17   ` Robert Goldman
2011-04-22 14:07     ` Eric Schulte

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).