emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* org-program-exists vs executable-find
@ 2012-04-18 12:46 Sebastien Vauban
  2012-04-18 13:25 ` Bastien
  0 siblings, 1 reply; 9+ messages in thread
From: Sebastien Vauban @ 2012-04-18 12:46 UTC (permalink / raw)
  To: emacs-orgmode-mXXj517/zsQ

Hello,

While browsing the Org code, I've found the function `org-program-exists':

#+begin_src emacs-lisp
  (defun org-program-exists (program-name)
    "Checks whenever we can locate program and launch it."
    (if (member system-type '(gnu/linux darwin))
        (= 0 (call-process "which" nil nil nil program-name))))
#+end_src

It is used 3 times in `org-clock.el', nowhere else.

On the contrary, `executable-find' is used 10 times in the Org code base (in
4 different libraries).

Shouldn't we better use `executable-find' everywhere, instead of
`org-program-exists' (which, btw, fails on Windows systems, even when they
have the Cygwin `which' at their disposal)?

I'm ready to submit a patch for this.

Best regards,
  Seb

-- 
Sebastien Vauban

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2012-06-14 13:05 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-18 12:46 org-program-exists vs executable-find Sebastien Vauban
2012-04-18 13:25 ` Bastien
2012-04-18 14:39   ` Sebastien Vauban
2012-04-20 11:22     ` Bastien
2012-04-20 20:24       ` Sebastien Vauban
2012-04-20 20:42         ` Martyn Jago
2012-04-21 10:13         ` Achim Gratz
2012-04-28 21:44         ` Bastien
2012-06-14 13:05         ` Giovanni Ridolfi

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).