From: Martyn Jago <martyn.jago@btinternet.com>
To: emacs-orgmode@gnu.org
Subject: Re: org-program-exists vs executable-find
Date: Fri, 20 Apr 2012 21:42:43 +0100 [thread overview]
Message-ID: <m27gxab0e4.fsf@btinternet.com> (raw)
In-Reply-To: 80ehrinobo.fsf@somewhere.org
Hi
"Sebastien Vauban"
<wxhgmqzgwmuf@spammotel.com> writes:
> Hi Bastien,
>
> Bastien wrote:
>> "Sebastien Vauban" <wxhgmqzgwmuf@spammotel.com> writes:
>>
>>>> The name `org-program-exists' is actually misleading, it should be
>>>> `org-executable-call' instead, while still checking if the executable
>>>> exists before calling it.
>>>
>>> Nope, the name is not misleading. The documentation string is false -- what
>>> I hadn't noticed, btw.
>>>
>>> That function just checks if the executable can be found; it does _not_
>>> call it afterward.
>>
>> You're right, I just fixed the docstring.
>>
>>> On Linux and Mac OS, it just calls "which + <program name>", no more... On
>>> Windows, it simply fails immediately (even if the program could be found).
>>
>> If there is an equivalent of `which' on windows let me know,
>
> Not that I know, reason why I (must) have Cygwin...
>
>> we can generalize this function.
>
> Why not replacing it simply by `executable-find': I don't see what it adds to
> it? I would not say so if it was some upper abstraction, but I do feel
> they're simply the same.
>
> If not, the opposite should be done: replacing the 10 calls to
> `executable-find' by calls to `org-program-exists'...
>
> Best regards,
> Seb
IIRC on Mac OS `which' is not guaranteed to work anyway, since by default
the `which database' is not instantiated or maintained. I had to kick that
off manually here to have use of `which'.
Best, Martyn
next prev parent reply other threads:[~2012-04-20 20:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-18 12:46 org-program-exists vs executable-find Sebastien Vauban
2012-04-18 13:25 ` Bastien
2012-04-18 14:39 ` Sebastien Vauban
2012-04-20 11:22 ` Bastien
2012-04-20 20:24 ` Sebastien Vauban
2012-04-20 20:42 ` Martyn Jago [this message]
2012-04-21 10:13 ` Achim Gratz
2012-04-28 21:44 ` Bastien
2012-06-14 13:05 ` Giovanni Ridolfi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m27gxab0e4.fsf@btinternet.com \
--to=martyn.jago@btinternet.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).