emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* Bug: Missing end parenthesis in JavaScript regarding HTML exports [9.4.5 (9.4.5-73-g4c7696-elpaplus @ /home/sebbe/.emacs.d/elpa/develop/org-plus-contrib-20210503/)]
@ 2021-05-07  9:24 Sebastian Berntsson
  2021-05-08  7:38 ` Bastien
  0 siblings, 1 reply; 2+ messages in thread
From: Sebastian Berntsson @ 2021-05-07  9:24 UTC (permalink / raw)
  To: emacs-orgmode

Hi,

In lisp/ox-html.el in the function org-html-scripts, there's a missing
parenthesis in the JavaScript code which causes a syntax error.

The function (and line in question) is:
https://code.orgmode.org/bzg/org-mode/src/master/lisp/ox-html.el#L252

A `}` should be inserted right after that line.

To replicate the bug:
1. Export an .org file to HTML.
2. Open the HTML file in a browser and then open the developer tools in
the browser.
3. Click on the Console tab in the developer tools.
4. You should see a JavaScript syntax error in the console (if not, try
reloading the page with the developer tools open still).

This issue is causing my own JavaScript code to not run (as it is
inserted before the end of the <body> tag).

Thanks in advance for the eventual fix.

Kind regards,
Sebastian Berntsson

Emacs : GNU Emacs 27.2 (build 1, x86_64-redhat-linux-gnu, GTK+ Version 
3.24.28, cairo version 1.16.0)
of 2021-04-26
Package: Org mode version 9.4.5 (9.4.5-73-g4c7696-elpaplus @ 
/home/sebbe/.emacs.d/elpa/develop/org-plus-contrib-20210503/)



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Bug: Missing end parenthesis in JavaScript regarding HTML exports [9.4.5 (9.4.5-73-g4c7696-elpaplus @ /home/sebbe/.emacs.d/elpa/develop/org-plus-contrib-20210503/)]
  2021-05-07  9:24 Bug: Missing end parenthesis in JavaScript regarding HTML exports [9.4.5 (9.4.5-73-g4c7696-elpaplus @ /home/sebbe/.emacs.d/elpa/develop/org-plus-contrib-20210503/)] Sebastian Berntsson
@ 2021-05-08  7:38 ` Bastien
  0 siblings, 0 replies; 2+ messages in thread
From: Bastien @ 2021-05-08  7:38 UTC (permalink / raw)
  To: Sebastian Berntsson; +Cc: emacs-orgmode

Hi Sebastien,

Sebastian Berntsson <sebastian@ilait.se> writes:

> In lisp/ox-html.el in the function org-html-scripts, there's a missing
> parenthesis in the JavaScript code which causes a syntax error.

thanks for reporting this and sorry for this code typo, this is fixed
in maint and master now.

-- 
 Bastien


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-05-08  7:39 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-07  9:24 Bug: Missing end parenthesis in JavaScript regarding HTML exports [9.4.5 (9.4.5-73-g4c7696-elpaplus @ /home/sebbe/.emacs.d/elpa/develop/org-plus-contrib-20210503/)] Sebastian Berntsson
2021-05-08  7:38 ` Bastien

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).