emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@gmail.com>
To: Max Nikulin <manikulin@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH v2] org.el: Preserve case for link subgroups from `org-file-apps'
Date: Fri, 09 Sep 2022 19:10:49 +0800	[thread overview]
Message-ID: <874jxg3irq.fsf@localhost> (raw)
In-Reply-To: <tfcunv$cd2$1@ciao.gmane.io>

Max Nikulin <manikulin@gmail.com> writes:

> Evey attempt to read this function gives a new surprise. I agree that 
> dlink has no sense any more, see the new patches.

Applied onto main.

>> So, it is probably safe to drop it, especially if tests are passing.
> There is no tests for `org-open-file'. Checking of file existence, 
> running an asynchronous process make it harder to create such tests.

We need mocking, I guess (aka cl-letf).

Ihor Radchenko,
Org mode contributor,
Learn more about Org mode at https://orgmode.org/.
Support Org development at https://liberapay.com/org-mode,
or support my work at https://liberapay.com/yantar92

      reply	other threads:[~2022-09-09 11:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-05  7:15 [PATCH] org.el: Preserve case for link subgroups from `org-file-apps' Max Nikulin
2022-09-06 12:07 ` Ihor Radchenko
2022-09-08 14:37   ` [PATCH v2] " Max Nikulin
2022-09-09 11:10     ` Ihor Radchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874jxg3irq.fsf@localhost \
    --to=yantar92@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=manikulin@gmail.com \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).