From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id EUIoFlYgG2O9ogAAbAwnHQ (envelope-from ) for ; Fri, 09 Sep 2022 13:15:34 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id 6CUpFFYgG2OH1QAAG6o9tA (envelope-from ) for ; Fri, 09 Sep 2022 13:15:34 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BA81A33CC5 for ; Fri, 9 Sep 2022 13:15:33 +0200 (CEST) Received: from localhost ([::1]:46276 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oWbyu-0002vK-T8 for larch@yhetil.org; Fri, 09 Sep 2022 07:15:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52858) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oWbtW-0005M9-DL for emacs-orgmode@gnu.org; Fri, 09 Sep 2022 07:09:58 -0400 Received: from mail-pf1-x42f.google.com ([2607:f8b0:4864:20::42f]:45815) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oWbtU-0006rR-JY for emacs-orgmode@gnu.org; Fri, 09 Sep 2022 07:09:58 -0400 Received: by mail-pf1-x42f.google.com with SMTP id z187so1321529pfb.12 for ; Fri, 09 Sep 2022 04:09:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date; bh=5HojYYCPoE3VPlfqTRNfoSjh3Om5bnMNuEdcae2qx3g=; b=k9wpLHK+2q/WtvhJcr4BOSSxqzQa1GGHheC6fYW9xo6ufFgPekteHqV/fKpWQ3lXPD YbVqh75iLuKUMDie4pZFgOn3ikROIn7NRpp4dD9rjO0iQRVQ+wAXox3DyEYEomP56Pz0 JCGmZIdtSmjC/Yu39k5nfRR2YeihvXGoVG8LE0y2s303dOOJos+XNyocbdn0kshIqkf4 o32920SDOQi8a2AGjuJdsp8I+Z/bimHTL9XPPqu24N4hPOircH2PDob+r0MvWD+pWbbH JP+PhIDdmkexZxw/VGLehm1ljcIePvxcE2aJhNVG/OtaS2HQKChz4HeAQoV+Ly5XbTrv hklg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date; bh=5HojYYCPoE3VPlfqTRNfoSjh3Om5bnMNuEdcae2qx3g=; b=NDkh8upfnb7J0k5vOhPspIEcQh/KuDtWye/Q4QcmatQhVQivN+SYMAZr3B6s694iJe gHGbZ0f3d8Hhvv9KOh2oA3hj3QN1APTv2LFKk70nM0tk+NqP9sHGJ7+jOQBNRDbUPU3W GRzL0o+71A9sAFeUecDsi1chjxpfbCxbpclPtleGfY/ni4XY9zmkFBnJ7YpsuE3sbHlg pkhFFWe42wXjFqYhSaiifZTfj5jv/eNoMCguysIKMYdz6NgDwJdscPagIjY/jb1momt+ FDc9GMYHewOB09QztSjyL8RR+dNEr89PuG71HyVYdIOyCMTUBMm2GbJtgiIzq+UTk2dX 9CWA== X-Gm-Message-State: ACgBeo2UWBaTHiVzOcw1urrPmmP3giQ7yf/Oy9a4UrYmMXO3CTbqnQG9 gGWxJPF1A2reFH0z6ZGBOhXsf3pQ194= X-Google-Smtp-Source: AA6agR7seZ77Qp6j/KJ/CbiQfCibG/hoi+rYBQabRuVwLW7g1t4VT68h7FTvlXSBSbEmCtSaZL3KDw== X-Received: by 2002:a63:5b61:0:b0:41d:3227:37b8 with SMTP id l33-20020a635b61000000b0041d322737b8mr11652916pgm.265.1662721795457; Fri, 09 Sep 2022 04:09:55 -0700 (PDT) Received: from localhost ([2409:8a70:2b2:5800:8ec6:81ff:fe70:339d]) by smtp.gmail.com with ESMTPSA id d4-20020a170902654400b001749dff717dsm182615pln.227.2022.09.09.04.09.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Sep 2022 04:09:54 -0700 (PDT) From: Ihor Radchenko To: Max Nikulin Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH v2] org.el: Preserve case for link subgroups from `org-file-apps' In-Reply-To: References: <8735d4wvsy.fsf@localhost> Date: Fri, 09 Sep 2022 19:10:49 +0800 Message-ID: <874jxg3irq.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::42f; envelope-from=yantar92@gmail.com; helo=mail-pf1-x42f.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1662722134; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=5HojYYCPoE3VPlfqTRNfoSjh3Om5bnMNuEdcae2qx3g=; b=HBj5CiVToiQNNrkneLaEZKameuD06GGFn3P1JrehhmsRKiQsj4dIIwkQa520swOZUUOpFy kasb0dTI7ejRUrbACo2/rrP+lv32A4yw4wlebY3KJbpdSbweePIqkbo9GWi5Y67t26r5tE 81g3T0Goi+IPR3iF5qq8ySQ21PMFXL51uP+mPphHbNeKi6izwbuutqR2J4S24Ze2wt1MtT 6+OABiZonalIcHkRB6YpH3p/Ppb5cHIEpscwZ/87lbaUwxE1kEdEtIhFclssR4kqXZ50W7 s5dKZ9eV+iGwHemkU2w9tld+KVH9WZ0F1m/sy/tl5pqONO9v+guA0eM7+T5zvA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1662722134; a=rsa-sha256; cv=none; b=h7nl42Gu6s09huyX98iEeqTxOOiuSMYFjyE/pcvtPqX4+ZEzKjgCyd8u2J/BY4/H7Yn3rm BNF5B4QPl6X5+Aog6QAHSwReXQaWQnB4wgtUiuzKTds6ueQ56t1EXAiy4RutbcvbWS+aR4 GRuLcNISoweFICzIMIQfm0lX0CZAQgmqB30Hu52UVH2ODQFyyu9D8KxP0pJ74BSdEk7GJS Fd08VY7ZxPY86EcNK25YAcBjAyxsKf2Z61ahYNtG81UQZ+qZmgeUjt+fIx1kfjKBL5LvI9 aX4EWlQQ29nSNVwUmAXVcF17yktUKNIyVTb0QKGI4S3VRSAPidby484LbH8C4g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=k9wpLHK+; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.80 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=k9wpLHK+; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: BA81A33CC5 X-Spam-Score: -3.80 X-Migadu-Scanner: scn0.migadu.com X-TUID: dKZFy1XODFYk Max Nikulin writes: > Evey attempt to read this function gives a new surprise. I agree that > dlink has no sense any more, see the new patches. Thanks! Applied onto main. https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=33686b9955c011486a72ec548475651dcadb0339 https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=6e9ea3a0766de9df6992bfb0359a5826ed1951b5 https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=f25b308af671766bb01e507c6db57bf3e83d8d05 >> So, it is probably safe to drop it, especially if tests are passing. > > There is no tests for `org-open-file'. Checking of file existence, > running an asynchronous process make it harder to create such tests. We need mocking, I guess (aka cl-letf). -- Ihor Radchenko, Org mode contributor, Learn more about Org mode at https://orgmode.org/. Support Org development at https://liberapay.com/org-mode, or support my work at https://liberapay.com/yantar92